-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Summon to Discovery Showcase #7
Open
amusick-endava
wants to merge
25
commits into
ExLibrisGroup:main
Choose a base branch
from
amusick-endava:develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edit searchUrl to something we have access to as CDI team, on clarivate vpn
…code-to-make-it-generic Refactor current code to make it generic
refactor document card to be more generic
…service-for-carousel-snxService Implement summon service for carousel - snxService
Handle summon specific logic about default thumbnail in snx-service
Cdi 29326 add font-style to carousel
…earch url has changed
…nails-via-css-classes-like-in-results-page Use default thumbnails via css classes like in results page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:::
The risk here is around how we have changed names of components. For example pnx-card is now document-card. This would break styles for someone who wrote them expecting pnx-card but downloaded a new bundle and would require a change in documentation. https://developers.exlibrisgroup.com/blog/primo-showcase-how-to-embed/
If we want to go forward with adding Summon but be more cautious we can undo any renaming.