Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Summon to Discovery Showcase #7

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

amusick-endava
Copy link

  • Refactored existing discovery showcase such that search-carousel and document-card contain no parsing logic, dummy components that display parameterized data, and moved logic and parsing to pnx-search-carousel and pnx-service while moving shared logic to image-service
  • Added snx-search-carousel and snx-service for use by summon
  • Added snx-search-carousel to the index.html demo
  • rollup command now builds two separate bundles, one for pnx and another for snx
  • edited readme accordingly

NOTE:::
The risk here is around how we have changed names of components. For example pnx-card is now document-card. This would break styles for someone who wrote them expecting pnx-card but downloaded a new bundle and would require a change in documentation. https://developers.exlibrisgroup.com/blog/primo-showcase-how-to-embed/

If we want to go forward with adding Summon but be more cautious we can undo any renaming.

amusick-endava and others added 25 commits August 21, 2024 11:38
edit searchUrl to something we have access to as CDI team, on clarivate vpn
…code-to-make-it-generic

Refactor current code to make it generic
refactor document card to be more generic
…service-for-carousel-snxService

Implement summon service for carousel - snxService
Handle summon specific logic about default thumbnail in snx-service
Cdi 29326 add font-style to carousel
…nails-via-css-classes-like-in-results-page

Use default thumbnails via css classes like in results page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants