Change to multiphase hybrid coupling - both projections #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbkuhn
force-pushed
the
new_multiphase_hybrid_nodalcoupling
branch
2 times, most recently
from
c477cc3 to
3561144
Compare
mbkuhn
force-pushed
the
new_multiphase_hybrid_nodalcoupling
branch
2 times, most recently
from
cc3dfa9 to
9a6df6c
Compare
mbkuhn
force-pushed
the
new_multiphase_hybrid_nodalcoupling
branch
3 times, most recently
from
de26310 to
6058ff4
Compare
mbkuhn
force-pushed
the
new_multiphase_hybrid_nodalcoupling
branch
from
6058ff4 to
4ff8ff5
Compare
mbkuhn
force-pushed
the
new_multiphase_hybrid_nodalcoupling
branch
from
4ff8ff5 to
20390ea
Compare
…to make it more efficient and add unit test
mbkuhn
force-pushed
the
new_multiphase_hybrid_nodalcoupling
branch
from
37d079f to
65647a4
Compare
mbkuhn
changed the title
|
Still needs unit testing, but this should be ready for review. Need to confirm amr-wind reg tests are unchanged; these changes affect exawind-driver reg tests only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, spurious currents in multiphase hybrid cases were reduced by not coupling the nodal projection directly to the incoming pressure values. We have found issues with that, and the proposed change is coupling single-phase regions directly and loosely coupling around the interface.
We also made the same change for the MAC projection coupling, which means this PR enables a single approach that is compatible for both single-phase and multiphase overset needs.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Changes to regression tests of exawind-driver will go along with this, but they run fine with a few tweaks.