Remove lots of clang warnings (#1039)

* Remove clang warnings Leaving the c++17 warnings since we will update to c++17 soon * Unused code
Exawind · Sep 12, 2022 · f8508d4 · f8508d4
1 parent 88ca5b6
commit f8508d4
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 10 deletions.
diff --git a/include/SolverAlgorithm.h b/include/SolverAlgorithm.h
@@ -32,7 +32,7 @@ struct NGPApplyCoeff
   NGPApplyCoeff(EquationSystem*);
 
   KOKKOS_DEFAULTED_FUNCTION
-  NGPApplyCoeff() = default;
+  NGPApplyCoeff() = delete;
 
   KOKKOS_DEFAULTED_FUNCTION
   ~NGPApplyCoeff() = default;

diff --git a/include/node_kernels/BLTGammaM2015NodeKernel.h b/include/node_kernels/BLTGammaM2015NodeKernel.h
@@ -36,7 +36,7 @@ class BLTGammaM2015NodeKernel : public NGPNodeKernel<BLTGammaM2015NodeKernel>
   BLTGammaM2015NodeKernel(const stk::mesh::MetaData&);
 
   KOKKOS_FORCEINLINE_FUNCTION
-  BLTGammaM2015NodeKernel() = default;
+  BLTGammaM2015NodeKernel() = delete;
 
   KOKKOS_FUNCTION
   virtual ~BLTGammaM2015NodeKernel() = default;

diff --git a/src/edge_kernels/AMSMomentumEdgePecletAlg.C b/src/edge_kernels/AMSMomentumEdgePecletAlg.C
@@ -77,13 +77,9 @@ AMSMomentumEdgePecletAlg::execute()
   nalu_ngp::run_edge_algorithm(
     "compute_peclet_factor", ngpMesh, sel,
     KOKKOS_LAMBDA(const EntityInfoType& eInfo) {
-      NALU_ALIGNED DblType av[nalu_ngp::NDimMax];
       DblType udotx{0.0};
 
       const auto edge = eInfo.meshIdx;
-      for (int d = 0; d < ndim; d++) {
-        av[d] = edgeAreaVec.get(edge, d);
-      }
       const auto& nodes = eInfo.entityNodes;
       const auto nodeL = ngpMesh.fast_mesh_index(nodes[0]);
       const auto nodeR = ngpMesh.fast_mesh_index(nodes[1]);

diff --git a/src/edge_kernels/MomentumEdgePecletAlg.C b/src/edge_kernels/MomentumEdgePecletAlg.C
@@ -74,13 +74,9 @@ MomentumEdgePecletAlg::execute()
   nalu_ngp::run_edge_algorithm(
     "compute_peclet_factor", ngpMesh, sel,
     KOKKOS_LAMBDA(const EntityInfoType& eInfo) {
-      NALU_ALIGNED DblType av[nalu_ngp::NDimMax];
       DblType udotx{0.0};
 
       const auto edge = eInfo.meshIdx;
-      for (int d = 0; d < ndim; d++) {
-        av[d] = edgeAreaVec.get(edge, d);
-      }
       const auto& nodes = eInfo.entityNodes;
       const auto nodeL = ngpMesh.fast_mesh_index(nodes[0]);
       const auto nodeR = ngpMesh.fast_mesh_index(nodes[1]);