Implementation for R3xSO(3)-based rigid body solver as mass elements #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to increase readability of the code
…ts + start using it in residual vector assembly as a test case
… elements/masses to prepare for TDD of mass elements logic
… matrix + add vector of MassElement as an attribute of Model class
ddement
reviewed
Dec 13, 2024
ddement
reviewed
Dec 13, 2024
The linear solve now converges. However, the result is still incorrect (more debugging in progress).
…ions of the Rust code
ddement
force-pushed
the
rigid-body-solver
branch
from
d5b9b3f to
c04149d
Compare
…e names in Masses to be consistent with Beams
ddement
force-pushed
the
rigid-body-solver
branch
from
341d985 to
9f44adb
Compare
…_ptr. This also fixes a bug where the system matrix is not properly assembled when both Beams and Masses are present in the element.
ddement
force-pushed
the
rigid-body-solver
branch
from
e3e24e6 to
2122604
Compare
This change required creating different versions of our math kernels for Masses. I put these in a namespace openturbine::masses instead of putting _Masses at the end of the kernel name. I think this should be our pattern moving forward, but I don't want to proliferate the decision without consensus
ddement
force-pushed
the
rigid-body-solver
branch
2 times, most recently
from
baacfc3 to
1967ff0
Compare
ddement
force-pushed
the
rigid-body-solver
branch
from
1967ff0 to
44b107a
Compare
deslaughter
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements this.