Merge pull request #55395 from shubham1206agra/fix-onyx-file-error

Fixed Onyx serialization of FileObject
Expensify · Jan 23, 2025 · 16d5642 · 16d5642
2 parents 7746935 + 3ca19b1
commit 16d5642
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/libs/actions/OnyxUpdates.ts b/src/libs/actions/OnyxUpdates.ts
@@ -156,8 +156,14 @@ function apply({lastUpdateID, type, request, response, updates}: OnyxUpdatesFrom
  * @param [updateParams.updates] Exists if updateParams.type === 'pusher'
  */
 function saveUpdateInformation(updateParams: OnyxUpdatesFromServer) {
+    let modifiedUpdateParams = updateParams;
+    // We don't want to store the data in the updateParams if it's a HTTPS update since it is useless anyways
+    // and it causes serialization issues when storing in Onyx
+    if (updateParams.type === CONST.ONYX_UPDATE_TYPES.HTTPS && updateParams.request) {
+        modifiedUpdateParams = {...modifiedUpdateParams, request: {...updateParams.request, data: undefined}};
+    }
     // Always use set() here so that the updateParams are never merged and always unique to the request that came in
-    Onyx.set(ONYXKEYS.ONYX_UPDATES_FROM_SERVER, updateParams);
+    Onyx.set(ONYXKEYS.ONYX_UPDATES_FROM_SERVER, modifiedUpdateParams);
 }
 
 type DoesClientNeedToBeUpdatedParams = {