Skip to content

Commit

Permalink
Clean up terms used when adding a card feed
Browse files Browse the repository at this point in the history
  • Loading branch information
VickyStash committed Nov 25, 2024
1 parent f4f8da7 commit 1ab06c4
Show file tree
Hide file tree
Showing 14 changed files with 18 additions and 22 deletions.
6 changes: 2 additions & 4 deletions src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3230,9 +3230,8 @@ const translations = {
collect: 'Collect',
},
companyCards: {
addCompanyCards: 'Add company cards',
selectCardFeed: 'Select card feed',
addCardFeed: 'Add card feed',
addCards: 'Add cards',
selectCards: 'Select cards',
addNewCard: {
other: 'Other',
cardProviders: {
Expand Down Expand Up @@ -3480,7 +3479,6 @@ const translations = {
assignCards: 'Assign cards to the entire team',
automaticImport: 'Automatic transaction import',
},
ctaTitle: 'Add company cards',
},
disableCardTitle: 'Disable company cards',
disableCardPrompt: 'You can’t disable company cards because this feature is in use. Reach out to the Concierge for next steps.',
Expand Down
6 changes: 2 additions & 4 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3269,9 +3269,8 @@ const translations = {
collect: 'Recopilar',
},
companyCards: {
addCompanyCards: 'Agregar tarjetas de empresa',
selectCardFeed: 'Seleccionar feed de tarjetas',
addCardFeed: 'Añadir alimentación de tarjeta',
addCards: 'Añadir tarjetas',
selectCards: 'Seleccionar tarjetas',
addNewCard: {
other: 'Otros',
cardProviders: {
Expand Down Expand Up @@ -3522,7 +3521,6 @@ const translations = {
assignCards: 'Asignar tarjetas a todo el equipo',
automaticImport: 'Importación automática de transacciones',
},
ctaTitle: 'Añadir tarjetas de empresa',
},
disableCardTitle: 'Deshabilitar tarjetas de empresa',
disableCardPrompt: 'No puedes deshabilitar las tarjetas de empresa porque esta función está en uso. Por favor, contacta a Concierge para los próximos pasos.',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function WorkspaceCompanyCardFeedSelectorPage({route}: WorkspaceCompanyCardFeedS
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.selectCardFeed')}
title={translate('workspace.companyCards.selectCards')}
onBackButtonPress={goBack}
/>
<SelectionList
Expand All @@ -91,7 +91,7 @@ function WorkspaceCompanyCardFeedSelectorPage({route}: WorkspaceCompanyCardFeedS
initiallyFocusedOptionKey={selectedFeed}
listFooterContent={
<MenuItem
title={translate('workspace.companyCards.addCompanyCards')}
title={translate('workspace.companyCards.addCards')}
icon={Expensicons.Plus}
onPress={() => {
CompanyCards.clearAddNewCardFlow();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ function WorkspaceCompanyCardPageEmptyState({policy}: WithPolicyAndFullscreenLoa
menuItems={companyCardFeatures}
title={translate('workspace.moreFeatures.companyCards.feed.title')}
subtitle={translate('workspace.moreFeatures.companyCards.subtitle')}
ctaText={translate('workspace.moreFeatures.companyCards.feed.ctaTitle')}
ctaAccessibilityLabel={translate('workspace.moreFeatures.companyCards.feed.ctaTitle')}
ctaText={translate('workspace.companyCards.addCards')}
ctaAccessibilityLabel={translate('workspace.companyCards.addCards')}
onCtaPress={startFlow}
illustrationBackgroundColor={colors.blue700}
illustration={Illustrations.CompanyCardsEmptyState}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function AmexCustomFeed() {
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function BankConnection({policyID}: BankConnectionStepProps) {
type={CONST.MODAL.MODAL_TYPE.CENTERED_UNSWIPEABLE}
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>
<FullPageOfflineBlockingView>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function BankConnection({policyID}: BankConnectionStepProps) {
return (
<ScreenWrapper testID={BankConnection.displayName}>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>
<BlockingView
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ function CardInstructionsStep({policyID}: CardInstructionsStepProps) {
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>
<ScrollView
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/addNew/CardNameStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function CardNameStep() {
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>
<Text style={[styles.textHeadlineLineHeightXXL, styles.ph5, styles.mv3]}>{translate('workspace.companyCards.addNewCard.whatBankIssuesCard')}</Text>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/addNew/CardTypeStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function CardTypeStep() {
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>

Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/addNew/DetailsStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ function DetailsStep({policyID}: DetailsStepProps) {
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>
<FormProvider
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/addNew/SelectBankStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ function SelectBankStep() {
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>

Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/addNew/SelectFeedType.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ function SelectFeedType() {
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.addCardFeed')}
title={translate('workspace.companyCards.addCards')}
onBackButtonPress={handleBackButtonPress}
/>

Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/members/WorkspaceMemberNewCardPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ function WorkspaceMemberNewCardPage({route, personalDetails}: WorkspaceMemberNew
shouldEnableMaxHeight
>
<HeaderWithBackButton
title={translate('workspace.companyCards.selectCardFeed')}
title={translate('workspace.companyCards.selectCards')}
onBackButtonPress={goBack}
/>
<SelectionList
Expand Down

0 comments on commit 1ab06c4

Please sign in to comment.