[HOLD for payment 2025-01-02] [HOLD for payment 2024-12-30] [$250] HybridApp iOS build errors after react-native-live-markdown update to 0.1.207

[AndrewGable]

Problem

iOS HybridApp will not build on main because of compilation errors:

/Users/andrew/Expensidev/App/node_modules/@expensify/react-native-live-markdown/cpp/MarkdownGlobal.h:5:10: 'worklets/WorkletRuntime/WorkletRuntime.h' file not found

This is being tracked in react-native-live-markdown here: Expensify/react-native-live-markdown#588

Slack discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1734385675583269

Solution

Fix the compilation errors with a patch, library update, or reverting #53627

cc @tomekzaw @luacmartins

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021869470396739967874
• Upwork Job ID: 1869470396739967874
• Last Price Increase: 2024-12-18

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[AndrewGable]

This should block the next deploy. @tomekzaw is working on a fix now.

[tomekzaw]

Here's the fix: Expensify/react-native-live-markdown#589

Once merged, we'll need to bump @expensify/react-native-live-markdown in E/App to 2.1.209.

[tomekzaw]

Submitted a PR with version bump: #54265

[ZhenjaHorbach]

@AndrewGable
Could we reopen this issue please ?
Since I reviewed this PR

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021869470396739967874

[melvin-bot]

Current assignee @ZhenjaHorbach is eligible for the External assigner, not assigning anyone new.

[sonkeydotcom]

Can I work on this

[AndrewGable]

No - It's been fixed.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.77-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Bump react-native-live-markdown to 0.1.209 #54265

If no regressions arise, payment will be issued on 2024-12-30. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

@ZhenjaHorbach @strepanier03 @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] Bump react-native-live-markdown to 0.1.209 #54265

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

@ZhenjaHorbach @strepanier03 @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[ZhenjaHorbach]

@ZhenjaHorbach @strepanier03 @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: HERE

I'm not sure we need a checklist for this one
Since it's a very specific case which is related to builds

But if needed

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Bump react-native-live-markdown (use worklets) #53627 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1734385675583269

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Tests are not needed here
Since the issue is related to builds

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ZhenjaHorbach paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1869470396739967874/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@AndrewGable, @strepanier03, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!