Fix build with USE_FRAMEWORKS=static
#589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2024
luacmartins
approved these changes
Dec 17, 2024
|
Thanks @luacmartins for approving this! |
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #588.
Fixes Expensify/App#54256.
This PR fixes failing iOS build with
USE_FRAMEWORKS=staticcaused by two problems.'worklets/WorkletRuntime/WorkletRuntime.h' file not found– this is caused by incorrect header structure in react-native-reanimated whenUSE_FRAMEWORKS=staticis enabled. This is related to Fix static linking on iOS software-mansion/react-native-reanimated#6614. The workaround here is to find path tonode_modules/react-native-reanimated, append it withapple/orCommon/cpp/and add them to header search paths. This needs to be fixed in react-native-reanimated; once fixed there we can remove the workaround here.react/renderer/consistency/ShadowTreeRevisionConsistencyManager.hfile not found– this is resolved by declaring a dependency onReact-rendererconsistencypodspec whenUSE_FRAMEWORKS=staticis enabled. We already do the same thing forReact-FabricComponents`.Related Issues
GH_LINK
Manual Tests
Linked PRs