-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add loading indicator when ReconnectApp is running #52272
base: main
Are you sure you want to change the base?
Conversation
@nkdengineer what did we change here? what was the issue? |
|
@getusha friendly bump |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-11-25.at.2.28.59.in.the.afternoon.movAndroid: mWeb ChromeScreen.Recording.2024-11-25.at.2.15.33.in.the.afternoon.moviOS: NativeScreen.Recording.2024-11-26.at.10.25.05.at.night.moviOS: mWeb SafariScreen.Recording.2024-11-25.at.2.18.00.in.the.afternoon.movMacOS: Chrome / SafariScreen.Recording.2024-11-25.at.2.12.46.in.the.afternoon.movMacOS: DesktopScreen.Recording.2024-11-25.at.2.21.44.in.the.afternoon.mov |
Hi @getusha, how is this coming along? Do you think we can get this merged today or tomorrow? |
I'll try to wrap this up today 🙇 |
@nkdengineer
Screen.Recording.2024-11-26.at.10.20.12.at.night.mov |
@getusha Fixed this bug. |
@getusha Friendly bump. |
@shawnborton In large screen, the offline indicator in
In the small screen, the offline indicator is rendered in So the screen jump 1px because normally, the bottom in |
Got it, thanks for explaining. Can you adjust so that it always uses 16px for its height? |
@shawnborton Normally, if we don't have the offline indicator, the bottom in |
@shawnborton Got it, please help to see on the loading bar again if it has any other problem then we can be good to process. |
I think the loaders themselves are in a good spot. Let's get this into final review @getusha @srikarparsi . I'll also spin up a test build. Thanks! |
🚧 @shawnborton has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪 |
I agree with that Shawn. Not the biggest deal in the world, but we might as well get this perfect now so we don't have to revisit it. |
Yeah 1px down would be perfect 😇 |
@shawnborton Here is what we want, right? Screen.Recording.2025-01-16.at.17.07.00.movScreen.Recording.2025-01-16.at.17.06.39.mov |
That looks right to me 👍 |
I updated the PR with the result above. |
Yup, same! |
Looks good! Can't wait for this to be in the product again. It helps so much haha. |
@srikarparsi It's ready for your final review. |
Taking a look. @getusha, can you do a quick review as well since there have been some changes since the last review. I'm generating an Ad Hoc build. |
🚧 @srikarparsi has triggered a test build. You can view the workflow run here. |
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Hey @nkdengineer, looks like jest job 2 is failing. Also, is there a problem with the iOS build. I see it worked in a different PR around the same time. |
@srikarparsi The test is passed now. |
Details
Fixed Issues
$ #46611
PROPOSAL: #46611 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov