[HybridApp] Fix `Not found page` on shortcuts #53954

war-in · 2024-12-11T16:09:00Z

Explanation of Change

This PR fixes the Hmm it's not there... page when clicking on the static shortcuts.
Related OD PR: https://github.com/Expensify/Mobile-Expensify/pull/13327

Fixed Issues

$
PROPOSAL:

Tests

Open the app through a shortcut (quick action)
Verify that you were redirected to the correct page

Offline tests

QA Steps

Open the app through a shortcut (quick action)
Verify that you were redirected to the correct page

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2024-12-12T15:15:28Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

melvin-bot · 2024-12-13T11:04:23Z

@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

war-in · 2024-12-13T11:10:19Z

This PR requires Mobile-Expensify access so maybe @Julesssss would be the right person to test and review? 🙏

marcochavezf · 2024-12-13T15:41:32Z

Conflicts

github-actions · 2024-12-13T15:46:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

Julesssss

I see conflicts now

# Conflicts: # Mobile-Expensify # scripts/run-build.sh

github-actions · 2024-12-19T16:36:50Z

🚧 @Julesssss has triggered a test build. You can view the workflow run here.

github-actions · 2024-12-19T16:59:58Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2024-12-19T17:04:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53954/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53954/NewExpensify.dmg	https://53954.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2024-12-19T17:05:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

# Conflicts: # Mobile-Expensify # scripts/run-build.sh

# Conflicts: # Mobile-Expensify

github-actions · 2025-01-14T17:34:49Z

🚧 @marcochavezf has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-14T18:00:15Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53954/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53954/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53954/NewExpensify.dmg	https://53954.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

marcochavezf · 2025-01-15T02:26:46Z

Oops more conflicts

github-actions · 2025-01-15T17:18:16Z

🚧 @marcochavezf has triggered a test build. You can view the workflow run here.

github-actions · 2025-01-15T17:54:02Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53954/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/53954/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/53954/NewExpensify.dmg	https://53954.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2025-01-15T21:53:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

ishpaul777 · 2025-01-15T22:20:42Z

@war-in this does not work for me whenn ui is NewDot, it keeps stuck on bootscreen time and then user land on chat list screen

Screen.Recording.2025-01-16.at.3.48.23.AM.mov

same with android, first 2 options say app not installed and 3rd opens chat list screen

Screen.Recording.2025-01-16.at.4.06.07.AM.mov

when ui is OldDot it works well on IOS

Screen.Recording.2025-01-16.at.4.17.38.AM.mov

on android first 2 options say app not installed and 3rd works fine

Screen.Recording.2025-01-16.at.4.20.31.AM.mov

github-actions · 2025-01-15T23:50:21Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-01-16T00:21:29Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53954/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

war-in · 2025-01-16T12:47:31Z

@ishpaul777 Have you tested that with the related OD PR?
Those changes are crucial and sorry for not mentioning them in the description earlier 🤦

war-in · 2025-01-16T13:57:06Z

And also thanks for pointing out the iOS issues 🙏 I tested it again and it turned out that there was some missing code in OD PR. Thank you!

ishpaul777 · 2025-01-16T19:55:41Z

No prob, pulled the PR code and started the build will update soon with test results

ishpaul777 · 2025-01-16T21:21:50Z

works well for IOS now but android still has same problem as in #53954 (comment)

Screen.Recording.2025-01-17.at.2.18.48.AM.mov

github-actions · 2025-01-17T14:17:07Z

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-01-17T14:51:55Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/53954/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

fix Not found page on shortcuts

4d60d3a

Julesssss added the Ready To Build label Dec 12, 2024

This comment has been minimized.

Sign in to view

jnowakow mentioned this pull request Dec 13, 2024

[HOLD for payment 2025-01-02] Enable HybridApp test builds in App repo #51636

Open

war-in added 2 commits December 13, 2024 10:38

Merge branch 'main' into war-in/fix-static-shortcuts

530509d

make adhoc locally buildable

99d155a

war-in changed the title ~~Fix Not found page on shortcuts~~ [HybridApp] Fix Not found page on shortcuts Dec 13, 2024

war-in marked this pull request as ready for review December 13, 2024 11:03

war-in requested a review from a team as a code owner December 13, 2024 11:03

melvin-bot bot requested review from marcochavezf and removed request for a team December 13, 2024 11:04

bump submodule

beb05d1

Julesssss requested changes Dec 16, 2024

View reviewed changes

war-in added 2 commits December 19, 2024 15:46

Merge branch 'main' into war-in/fix-static-shortcuts

1622908

# Conflicts: # Mobile-Expensify # scripts/run-build.sh

bump submodule

6d9327e

war-in added 5 commits January 13, 2025 11:31

Merge branch 'main' into war-in/fix-static-shortcuts

39dc71d

# Conflicts: # Mobile-Expensify # scripts/run-build.sh

fix setting new ReactNativeActivity props

54ada19

move patch, hide boot splash

f6abc4a

Merge branch 'main' into war-in/fix-static-shortcuts

f709d9e

# Conflicts: # Mobile-Expensify

move patch to correct repo

43ff183

war-in added 2 commits January 15, 2025 10:19

resolve submodule conflict

a363c64

Merge branch 'main' into war-in/fix-static-shortcuts

f8ef4e6

marcochavezf requested a review from ishpaul777 January 15, 2025 20:58

Merge branch 'main' into war-in/fix-static-shortcuts

29d9c93

Julesssss self-requested a review January 16, 2025 18:04

Merge branch 'main' into war-in/fix-static-shortcuts

5e37c54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HybridApp] Fix `Not found page` on shortcuts #53954

[HybridApp] Fix `Not found page` on shortcuts #53954

war-in commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024

This comment has been minimized.

melvin-bot bot commented Dec 13, 2024

war-in commented Dec 13, 2024

marcochavezf commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

Julesssss left a comment

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

marcochavezf commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025 •

edited

Loading

ishpaul777 commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 16, 2025

war-in commented Jan 16, 2025

war-in commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025

github-actions bot commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

[HybridApp] Fix Not found page on shortcuts #53954

Are you sure you want to change the base?

[HybridApp] Fix Not found page on shortcuts #53954

Conversation

war-in commented Dec 11, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Dec 12, 2024

This comment has been minimized.

melvin-bot bot commented Dec 13, 2024

war-in commented Dec 13, 2024

marcochavezf commented Dec 13, 2024

github-actions bot commented Dec 13, 2024

Julesssss left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

marcochavezf commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

ishpaul777 commented Jan 15, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Jan 15, 2025 • edited Loading

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 16, 2025

war-in commented Jan 16, 2025

war-in commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025

ishpaul777 commented Jan 16, 2025

github-actions bot commented Jan 17, 2025

github-actions bot commented Jan 17, 2025

[HybridApp] Fix `Not found page` on shortcuts #53954

[HybridApp] Fix `Not found page` on shortcuts #53954

war-in commented Dec 11, 2024 •

edited

Loading

ishpaul777 commented Jan 15, 2025 •

edited

Loading

ishpaul777 commented Jan 15, 2025 •

edited

Loading