Implemented International Bank Account flow

[shubham1206agra]

Explanation of Change

Fixed Issues

$ #51082
$ #54743

Tests

https://docs.google.com/document/d/1H1hMnTcMrR8MT6BXz3fCE99eVIurgrHDtaxIH5aW8Ug/edit#heading=h.nhtsmauf72jq

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-25.at.5.24.19.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-11-25.at.4.46.43.PM.mov

iOS: Native

Screen.Recording.2024-11-25.at.5.08.17.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-11-25.at.4.29.32.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-25.at.4.23.43.PM.mov

MacOS: Desktop

Screen.Recording.2024-11-25.at.4.59.34.PM.mov

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[shubham1206agra]

Personal List.

• Bank Account - User does not land back on the country selector after closing the plaid UI. #54737 - a060234
• Wallet - Error indicating a selection is required is not shown in account selection page #54738 - 6b982b3
• Wallet - Corpay error message is not shown for invalid account and Swift Code #54745 - Not a bug as per comment
• Wallet - Bank name and account holder name fields accept emoji as name #54752 - BE issue
• Wallet - Country list does not auto scroll up when showing search result #54757 - da88626
• Wallet - Error message indicates "swift code" as "routing number" #54711 - BE issue
• Wallet - Bank account subtitle shows undefined after adding bank account #54707 - BE issue
• [$250] Wallet - Excluded countries and their currencies are shown #54741 - c07ec58
• Wallet - Account number field shows two error messages when it is empty #54692 - 3cddf30
• Wallet - Selected account type is not shown after returning back #54739 - 300a666
• Wallet - Currency does not auto update after changing country #54694 - ca22f9b
• [$250] Wallet -Order of bank & account holder fields is different on individual page and confirm page #54709 - d9e53a9
• Wallet - Checkbox on confirmation page becomes unchecked after returning from field editor #54720 - d88fe50
• [$250] Wallet - Prior bank account detail inputs are not shown. #54740 - d88fe50
• [$250] Wallet - In offline mode, no full blocking view in country page, country & currency are editable #54746 - cef7c93
• Wallet - The top of the confirmation page header is not “Check your info.” #54749 - 976956e
• Wallet - Error for invalid IBAN should be "Invalid IBAN" instead of "400 invalid IBAN" #54751 - BE issue
• Wallet - Account number field is not focused #54742
• Wallet - Make default payment method option uses a message icon instead of star icon #54750 - 13a8197

[melvin-bot]

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shubham1206agra]

@allroundexperts Please ignore this PR.

[shubham1206agra]

@DylanDylann Please follow the test doc this time as QA will send us bugs that should not be sent.

[shubham1206agra]

@DylanDylann Crash should be fixed now

[DylanDylann]

@shubham1206agra

Offline - Mid-deposit account flow > Step 7

Currently, we don't disable anything on this page in offline mode

[shubham1206agra]

@shubham1206agra

Offline - Mid-deposit account flow > Step 7

Currently, we don't disable anything on this page in offline mode

@DylanDylann Fixed

[shubham1206agra]

@shubham1206agra Follow by Non-US deposit accounts overflow menu > Step 12

we have two non-US bank accounts and one of them is marked as default. If we remove the default bank account, the remaining one isn't marked as default automatically

This is a BE bug. cc @MonilBhavsar

[shubham1206agra]

@DylanDylann Is your testing complete? Or is there anything else that remains?

[DylanDylann]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[DylanDylann]

@MonilBhavsar The rest looks fine to me. I will retest this PR again after we complete the above discussion (and discussion on Slack) in case we need to update more things

[MonilBhavsar]

This is the only discussion pending #54798 (comment), right?

[DylanDylann]

@MonilBhavsar @shubham1206agra Currently we have 4 pending problems:

• Wallet - Account number field is not focused #54742 (Need to confirm the expect again)
• [$250] Wallet - In offline mode, no full blocking view in country page, country & currency are editable #54746 (comment) (minor bug, waiting for @shubham1206agra to fix it)
• https://expensify.slack.com/archives/C06ML6X0W9L/p1737011678039919?thread_ts=1729597274.005059&cid=C06ML6X0W9L (Discussing with @joekaufmanexpensify)
• Implemented International Bank Account flow #54798 (comment) (BE Bug, need an eye from @MonilBhavsar)

[MonilBhavsar]

#54742 (Need to confirm the expect again)

We should definitely focus an input field. Not sure why we expect the second field i.e. account number and not the first field - swift code. May be because it is optional? cc @joekaufmanexpensify

#54798 (comment) (BE Bug, need an eye from @MonilBhavsar)

I will test it today and fix it, if required

[shubham1206agra]

We should definitely focus an input field. Not sure why we expect the second field i.e. account number and not the first field - swift code. May be because it is optional? cc @joekaufmanexpensify

@MonilBhavsar I thought auto focus is for pages with single input. So, I am not sure why we need to add focus here. Btw, lets not block merge on this. We can take this in follow up if needed.

[MonilBhavsar]

Also, i think we should add this to beta so we don't have to revert, in case a bug is found

[DylanDylann]

Also, i think we should add this to beta so we don't have to revert, in case a bug is found

@shubham1206agra Could you do that? Then we can move forward this PR and handle other problems in another PR

[DylanDylann]

Daily Update

• Waiting for @shubham1206agra to update: https://expensify.slack.com/archives/C06ML6X0W9L/p1737035775604899?thread_ts=1729597274.005059&cid=C06ML6X0W9L
• Need to discuss more: Implemented International Bank Account flow #54798 (comment)
• Waiting for @MonilBhavsar to check: Implemented International Bank Account flow #54798 (comment)

If we hide this feature behind the beta flag, we can move forward with this PR and handle the three above problems later

[shubham1206agra]

Waiting on @MonilBhavsar to create a beta flag.

[shubham1206agra]

@DylanDylann You can finish the review now.