Early discount countdown banner

[parasharrajat]

Explanation of Change

Fixed Issues

$ #54817
PROPOSAL: #54817 (comment)

Tests

Claiming the first discount

1. Sign up as a new user
2. Create a workspace
3. Go to your onboarding chat or concierge
4. Verify you can see a countdown timer starting from 24h.
5. Verify the banner is not dismissable.
6. Verify click on “Claim offer” takes you to the subscription page.
7. Verify the subscription page shows the same timer.
8. Verify that after you add a card, a promoCode of 50% has been applied to your account. Verify

Claiming the second discount

1. Sign up as a new user
2. Create a workspace
3. Modify the NVP firstDayFreeTrial such that it's earlier than 24h. Run this in the console: Onyx.merge("nvp_private_firstDayFreeTrial", "2024-12-21 23:36:00");
4. Go to your onboarding chat or concierge
5. Verify you can see a countdown showing days, hours, minutes, and seconds of the time remaining, which should be max 7 days when it starts.
6. Verify the banner is dismissable.
7. Verify click on “Claim offer” takes you to the subscription page.
8. Verify the subscription page shows the same timer.

Period past 8 days

1. Sign up as a new user
2. Create a workspace
3. Modify the NVP firstDayFreeTrial such that it's later than 8 days. Run this in the console: Onyx.merge("nvp_private_firstDayFreeTrial", "2024-12-21 23:36:00");
4. Verify no banner is shown in the onboarding chat.
5. Verify no banner is shown in the subscription page.
6. Verify that in the subscription, we’re showing the usual free trial banner instead.

• Verify that no errors appear in the JS console

Offline tests

Same as QA steps.

QA Steps

Prerequisites:

1. Sign up as a new user
2. Create a workspace.
3. Create an Expense on the workspace to begin a new trial.

Claiming the first discount

1. Go to your onboarding chat or concierge.

2. Verify you can see a countdown timer starting from 24h.

3. Verify the banner is not dismissable.

4. Verify that clicking on “Claim offer” takes you to the subscription page.

5. Verify the subscription page shows the same timer.

6. [Depends if backend has implemented the changes] Verify that after you add a card, a promoCode of 50% has been applied to your account.

Claiming the second discount

1. Login with the same account 24 hours from the trial's start.
2. Go to your onboarding chat or concierge.
3. Verify you can see a countdown showing days, hours, minutes, and seconds of the time remaining, which should be max 7 days when it starts.
4. Verify the banner is dismissible.
5. Verify that clicking on “Claim offer” takes you to the subscription page.
6. Verify the subscription page shows the same timer.

Period past 8 days

1. Login with the same account 8 days from the trial's start.
2. Verify no banner is shown in the onboarding chat.
3. Verify no banner is shown on the subscription page.
4. Verify that in the subscription, we’re showing the usual free trial banner instead.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

17.01.2025_15.26.54_REC.mp4

Android: mWeb Chrome

17.01.2025_15.29.45_REC.mp4

iOS: Native

17.01.2025_15.51.53_REC.mp4

iOS: mWeb Safari

17.01.2025_15.52.46_REC.mp4

MacOS: Chrome / Safari

17.01.2025_15.27.39_REC.mp4

MacOS: Desktop

17.01.2025_15.34.37_REC.mp4

[melvin-bot]

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[shawnborton]

Let us know when this is ready for design review!

[youssef-lr]

Can we get some screenshots for the design team please?

[github-actions]

🚧 @youssef-lr has triggered a test build. You can view the workflow run here.

[parasharrajat]

Added web. Adding more in sometime.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/54901/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/54901/index.html
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/54901/NewExpensify.dmg	https://54901.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[dannymcclain]

A couple things from the screenshots/videos so far:

• The banner in the chat view should use our row-hover color for the background
  • 
• I believe the first 50% off offer that's available for 24 hours is not supposed to be dismissible
• I thought we said the follow-up offer (25% off for 7 days) would be dismissible
  • 

Would love clarification about the offers and which should be dismissible, but the banner color in the chat needs to be updated regardless.

[youssef-lr]

I believe the first 50% off offer that's available for 24 hours is not supposed to be dismissible

That's correct, I believe I had it coded this way. @parasharrajat can you check?

[youssef-lr]

Added a suggestion in the code to fix that

[parasharrajat]

yes, I just enabled it from code for design team.

[youssef-lr]

ahh I see, okay cool then, let's keep it enabled until the design is good then we can revert.

[dannymcclain]

Oh I also just noticed that I think we need to update the timer text color on the subscriptions page banner. It looks like it's using text-supporting right now but that looks pretty terrible in light mode so I think we should update to what we have in Figma:

I believe the main text and background colors are already correct 👍

[parasharrajat]

Should these banner be visible on mobile? I am not seeing any??? 🤔

[shawnborton]

Great catches Danny! Agree with all of that, and thanks for laying it all out so clearly.

@parasharrajat I'm trying the test build with a new account and a new workspace, but I don't see the discount banner. Am I doing something wrong?

[parasharrajat]

You need to create a woekspace and then an expense to start free trial.

I will add that to test steps.

[shawnborton]

When the trial starts, I feel like we should remove the green button from the very top header here:

So that this way we only have one green button on the screen. Thoughts? I would even be down to put a little star icon in the Claim offer button.

[shawnborton]

Mobile styles do not look correct to me:

From the design doc:

Also, interesting that I'm not getting an #admins room even though I have a workspace... is that intentional?

[dannymcclain]

When the trial starts, I feel like we should remove the green button from the very top header here:

Yeah I agree—there's no reason to have that button there if you've already started a trial. What would it even do if you clicked on it?

So that this way we only have one green button on the screen. Thoughts? I would even be down to put a little star icon in the Claim offer button.

Also not against this! But I don't feel strongly about it either.

[dubielzyk-expensify]

So that this way we only have one green button on the screen. Thoughts? I would even be down to put a little star icon in the Claim offer button.

Maybe just me but I prefer it without, but don't feel strongly

[parasharrajat]

Bump @eVoloshchak

[parasharrajat]

All styles changes were made.

[dannymcclain]

Updated videos are looking better, thanks!

Seems like in some of the videos there's a No thanks button and in others there's not—why is that?

[parasharrajat]

For testing, I added the button forcefully so that you can see the whole UI. End result will have it based on the design.

[dannymcclain]

Awesome, thanks!

[shawnborton]

Nice, yeah this is lookin' good!

[youssef-lr]

@parasharrajat eslint is failing

[parasharrajat]

@youssef-lr Those files are unrelated to this PR.

[parasharrajat]

Fixed the lint issue.