add tasks for new user first workspace

[ishpaul777]

Explanation of Change

Fixed Issues

$ #53509
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

1. Sign up with new account and choose "Track and budget expense" in onboarding user intent.
2. Track a expense
3. in Selfdm choose to categorize it or share it with my accountant complete the flow.
4. Verify in you conceriege chat there are new tasks and with a message "Here are some important tasks to help get your team’s expenses under control." and a video

Test 2

1. Sign up with new account and choose any other option than "Manage my team's expense" in onboarding flow user intent.
2. Create a new worksapce
3. Verify in you conceriege chat there are new tasks and with a message "Here are some important tasks to help get your team’s expenses under control." and a video

Offline tests

QA Steps

Same as test steps

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-17.at.11.43.00.PM.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-01-18.at.3.24.19.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-18.at.3.41.30.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-17.at.3.53.34.AM.mov

MacOS: Desktop

[melvin-bot]

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ishpaul777]

@shubham1206agra please ignore this one

---

@mananjadhav will review this

[francoisl]

Reassigning C+ for review, this is coming from #55017. Thanks

[mananjadhav]

Checked the code, did one pass and most of it looks good. @ishpaul777 Can you complete the author checklist?

I also checked a possibility of refactoring the prepareOnboardingOptimisticData but it's too large to be moved outside of actions. I thought we could send the data with buildPolicyData.

Asking the same question here #55017 (comment).

@francoisl Should we ignore the rule for this particular instance?

[francoisl]

Looking good - a few things:

• We need to update this line to also include the new TRACK_WORKSPACE const – basically now any time we create a workspace, the onboarding tasks should be in the #admins room, not in the Concierge chat, and so the targetChatReportID should be the optimistic admin room's ID.
  

  App/src/libs/actions/Report.ts

  Line 3618 in 1063cfa

  const shouldPostTasksInAdminsRoom = engagementChoice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM && !currentUserEmail?.includes('+');

• I'm noticing a bug where the video comment is not rendering and stays as [Attachment] forever. That's a backend issue that I'm fixing now, so you can ignore for now
  

• Regarding the no-call-actions-from-actions failure, I'm kind of confused. The action says it's failing on line 2303, which is function createWorkspaceFromIOUPayment(), which hasn't changed here... Or is it because of prepareOnboardingOnyxData()? Regardless, as far as I can tell, that action should only fail if you call an action within an action that calls the API (https://github.com/Expensify/eslint-config-expensify/blob/acac69e60be8c/eslint-plugin-expensify/no-call-actions-from-actions.js), which neither prepareOnboardingOnyxData() nor buildPolicyData() does 🙃 I don't feel great about ignoring the rule without fully understanding why it's even erroring now.

[ishpaul777]

We need to update this line to also include the new TRACK_WORKSPACE const – basically now any time we create a workspace, the onboarding tasks should be in the #admins room, not in the Concierge chat, and so the targetChatReportID should be the optimistic admin room's ID.

will address this soon..

Can you complete the author checklist?

yes i'll do it right right after ^

[ishpaul777]

I'm noticing a bug where the video comment is not rendering and stays as [Attachment] forever. That's a backend issue that I'm fixing now, so you can ignore for now

there is also one more bug that this message "Here are some important tasks to help get your team’s expenses under control." goes away after createworkspace api command is success, can you please check that one as well please it looks like BE issue

[ishpaul777]

The action says it's failing on line 2303, which is function createWorkspaceFromIOUPayment(), which hasn't changed here... Or is it because of prepareOnboardingOnyxData()?

my best guess is that this because of prepareOnboardingOnyxData that is why its fixed with this d83382d workaround

[francoisl]

there is also one more bug that this message "Here are some important tasks to help get your team’s expenses under control." goes away after createworkspace api command is success

I'm not even seeing that message being sent in the CreateWorkspace payload, nor the video actually 🤔

[francoisl]

For some reason the video and message come back if I revert this commit.

[francoisl]

Did you happen to run into any issue with CreateWorkspace returning an error? I think it's a backend issue unfortunately, I'm looking into that now.

[ishpaul777]

@francoisl I have noticed a bug with workspace creation which i currently investigating right now please HOLD your review 🙇

[ishpaul777]

yes i think this is what i am invesigating #55302 (comment), maybe because of mistake some merge conflict resolve

[francoisl]

yes i think this is what i am invesigating #55302 (comment), maybe because of mistake some merge conflict resolve

Yeah I'm pretty sure it's a backend issue unfortunately that has to do with creating the setup tasks in the admins room on behalf of the Guide. I'm looking into it now but not sure yet if it will be an easy or complicated change.

[francoisl]

The backend fix for CreateWorkspace has been deployed, can you try again now please?

Sorry my bad it's not fully deployed yet, ignore this for now. I'll give another update when the deploy is complete.

[francoisl]

Ok now the fix is deployed for real, we can try again.

[ishpaul777]

@francoisl Can you please trigger adhoc builds

[github-actions]

🚧 @francoisl has triggered a test build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55302/index.html	❌ FAILED ❌
	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/55302/NewExpensify.dmg	https://55302.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[ishpaul777]

@francoisl I see we also receive another welcome message, is this expected in this case? also I noticed video and tasks video participant message got changed to [email protected] but not the the first message 👇

Screen.Recording.2025-01-25.at.1.18.52.AM.mov

[francoisl]

Yeah good point, I asked internally and we're going to skip the "Hi there 👋" message. You can ignore this for now, this will also be a backend change.
Sorry for the multiple changes needed, we didn't think about this at first because the original design was to create those tasks in the Concierge chat.

I noticed video and tasks video participant message got changed to [email protected] but not the the first message

Weird, not sure what's going on, I'll test on my end later.

[francoisl]

@ishpaul777 the message Here are some important tasks to help get your workspace set up isn't getting passed in the payload for CreateWorkspace - see in my screenshot below, the first object in guidedSetupData is the video.

[ishpaul777]

see in my screenshot below, the first object in guidedSetupData is the video.

oops! i fixed it now thanks for catching 🙇‍♂️

[francoisl]

Cool, thanks.
Other than that, I think everything else is ready to go? Can you finish filling out the author checklist please?

@mananjadhav you can probably start testing as well on your end, thanks!

[mananjadhav]

Yes I am on it. @ishpaul777 Can you merge with the latest main ?

[mananjadhav]

@ishpaul777 @francoisl do you see a need for adding a comment on why we're passing MANAGE_TEAM ?

[ishpaul777]

no strong feelings, but it feel self explanatory if we don't typescript will yell

[mananjadhav]

Reviewed the code changes, will do a final review once more and then start testing this.

[mananjadhav]

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[mananjadhav]

@ishpaul777 I had raised a comment earlier regarding the markdown text. Can you please take a look? The whole text starting from Invite your account... second bullet 2. Go to *Workspaces is bold.

Also I completed the Invite Accountant flow, I don't see the tasks on the Concierge chat.

[ishpaul777]

Also I completed the Invite Accountant flow, I don't see the tasks on the Concierge chat.

@mananjadhav does you test account includes a + in email. the way logic currently is if you have + in email it will be posted in conceirge chat otherwise it will be posted in admins room of new workspace.