Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddressStep.tsx #55327

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+3 −5
Open

Update AddressStep.tsx #55327

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c681ddb
Update AddressStep.tsx
jamesdeanexpensify Jan 15, 2025
0b5a7b3
Update en.ts
jamesdeanexpensify Jan 15, 2025
43ba807
Update src/pages/EnablePayments/PersonalInfo/substeps/AddressStep.tsx
jamesdeanexpensify Jan 16, 2025
b60504a
Update es.ts
jamesdeanexpensify Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ const translations = {
addressLine: ({lineNumber}: AddressLineParams) => `Address line ${lineNumber}`,
personalAddress: 'Personal address',
companyAddress: 'Company address',
noPO: 'PO boxes and mail drop addresses are not allowed',
noPO: 'No PO boxes or mail-drop addresses, please.',
jamesdeanexpensify marked this conversation as resolved.
Show resolved Hide resolved
city: 'City',
state: 'State',
streetAddress: 'Street address',
Expand Down Expand Up @@ -2201,7 +2201,6 @@ const translations = {
whatsYourLegalName: 'What’s your legal name?',
whatsYourDOB: 'What’s your date of birth?',
whatsYourAddress: 'What’s your address?',
noPOBoxesPlease: 'No PO boxes or mail-drop addresses, please.',
jamesdeanexpensify marked this conversation as resolved.
Show resolved Hide resolved
whatsYourSSN: 'What are the last four digits of your Social Security Number?',
noPersonalChecks: 'Don’t worry, no personal credit checks here!',
whatsYourPhoneNumber: 'What’s your phone number?',
Expand Down
2 changes: 1 addition & 1 deletion src/pages/EnablePayments/PersonalInfo/substeps/AddressStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
onMove={onMove}
formID={ONYXKEYS.FORMS.WALLET_ADDITIONAL_DETAILS}
formTitle={translate('personalInfoStep.whatsYourAddress')}
formPOBoxDisclaimer={translate('personalInfoStep.noPOBoxesPlease')}
formPOBoxDisclaimer={translate('common.noPo')}

Check failure on line 46 in src/pages/EnablePayments/PersonalInfo/substeps/AddressStep.tsx

View workflow job for this annotation

GitHub Actions / typecheck 

Argument of type '"common.noPo"' is not assignable to parameter of type 'TranslationPaths'.
jamesdeanexpensify marked this conversation as resolved.
Show resolved Hide resolved
onSubmit={handleSubmit}
stepFields={STEP_FIELDS}
inputFieldsIDs={INPUT_KEYS}
Expand Down
Loading