Bump react-fast-pdf #55421

rezkiy37 · 2025-01-17T16:54:59Z

Explanation of Change

The PR bumps the react-fast-pdf version where the legacy PDF.js worker has been applied.

Fixed Issues

$ #55176
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Note: especially test with IOS Safari 17.x.

Add any PDF attachment to a chat.
Open the attachment.
Verify that the attachment is displayed correctly.

Offline tests

Same as tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-01-17T17:04:10Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2025-01-18T15:08:22Z

@jjcoffee can you please test and add the checklist?

jjcoffee · 2025-01-20T09:02:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android-app-2025-01-20_10.27.17.mp4

Android: mWeb Chrome

android-chrome-2025-01-20_10.28.29.mp4

iOS: Native

ios-app-2025-01-20_11.10.51.mp4

iOS: mWeb Safari

ios-safari-2025-01-20_11.14.48.mp4

MacOS: Chrome / Safari

desktop-chrome-2025-01-20_10.15.35.mp4

MacOS: Desktop

desktop-app-2025-01-20_10.21.07.mp4

…ture/55176-bump-react-fast-pdf

rezkiy37 · 2025-01-20T09:42:10Z

@jjcoffee I've synced it up.

jjcoffee · 2025-01-20T10:13:57Z

BUG?: iOS App closes when back button pressed on PDF preview. No errors in the console that I can see.

ios-app-2025-01-20_11.10.51.mp4

jjcoffee · 2025-01-20T10:22:02Z

BUG?: iOS Safari loads the PDF container as 0px width initially before filling the width of the screen. I don't have iOS 18.x to test against staging, so I'm not sure if this is a new issue or not.

ios-safari-load-2025-01-20_11.20.57.mp4

rezkiy37 · 2025-01-20T11:07:26Z

BUG?: iOS App closes when back button pressed on PDF preview. No errors in the console that I can see.

ios-app-2025-01-20_11.10.51.mp4

It cannot relate to the PR or react-fast-pdf because it is not a native package. The app utilizes react-native-pdf for IOS and Android.

App/src/components/PDFView/index.tsx

Line 5 in 9c54d12

import {PDFPreviewer} from 'react-fast-pdf';

App/src/components/PDFView/index.native.tsx

Line 4 in 9c54d12

import PDF from 'react-native-pdf';

rezkiy37 · 2025-01-20T11:32:46Z

BUG?: iOS Safari loads the PDF container as 0px width initially before filling the width of the screen. I don't have iOS 18.x to test against staging, so I'm not sure if this is a new issue or not.

ios-safari-load-2025-01-20_11.20.57.mp4

Yes, this is the expected behavior because the legacy PDF.js worker was applied here - Expensify/react-fast-pdf#43. It works better with the latest worker but does not function on IOS 17.x.

jjcoffee · 2025-01-20T13:40:38Z

It cannot relate to the PR or react-fast-pdf because it is not a native package. The app utilizes react-native-pdf for IOS and Android.

Makes sense, I'm seeing the same behaviour on main too so definitely not to do with this PR!

jjcoffee

LGTM!

…ture/55176-bump-react-fast-pdf

rezkiy37 · 2025-01-21T11:50:48Z

One moment. Looks like I forgot to update the worker import in the project.

rezkiy37 · 2025-01-21T12:01:32Z

Done - 81b0523.

Screenshots

![Screenshot_20250121_125946_Chrome](https://github.com/user-attachments/assets/c59f722f-d4a3-4543-982f-e17b6e9aaad9)

cc @jjcoffee

mountiny

One change requested

package.json

…ackage.json

mountiny

Thanks!

OSBotify · 2025-01-21T21:48:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T18:28:59Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

tgolen · 2025-01-24T16:27:45Z

I think this warning I am getting in the webpack build was caused by this PR:

Is it going to be a problem?

tgolen · 2025-01-24T16:28:37Z

Things I have done to fix it:

npm i
rm -rf node_modules && npm i

Neither of them seems to fix it.

rezkiy37 · 2025-01-24T16:39:36Z

@tgolen, that's my bad because I set one incorrect import (w/ .min and w/o):

App/config/webpack/webpack.common.ts

Line 182 in 264728f

test: new RegExp('node_modules/pdfjs-dist/legacy/build/pdf.worker.mjs'),

App/src/components/PDFThumbnail/index.tsx

Line 3 in 264728f

import pdfWorkerSource from 'pdfjs-dist/legacy/build/pdf.worker.min.mjs';

I am working on a quick fix.

tgolen · 2025-01-24T16:59:37Z

Ah, cool. Thanks for working on a fix!

rezkiy37 · 2025-01-24T17:35:24Z

@tgolen Just opened for review #55743.

github-actions · 2025-01-28T01:52:24Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

bump react-fast-pdf to version 1.0.22

b36dc83

rezkiy37 changed the title ~~[WIP] Bump react-fast-pdf~~ Bump react-fast-pdf Jan 17, 2025

rezkiy37 marked this pull request as ready for review January 17, 2025 17:04

rezkiy37 requested a review from a team as a code owner January 17, 2025 17:04

melvin-bot bot requested a review from jjcoffee January 17, 2025 17:04

rezkiy37 mentioned this pull request Jan 17, 2025

[HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [mWeb iOS / Safari 17.2] - PDF attachment doesn't load (endless spinner) #55176

Open

8 tasks

melvin-bot bot removed the request for review from a team January 17, 2025 17:04

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

38c8f0c

…ture/55176-bump-react-fast-pdf

rezkiy37 closed this Jan 20, 2025

rezkiy37 reopened this Jan 20, 2025

jjcoffee approved these changes Jan 20, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny January 20, 2025 13:40

Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…

b67d6c7

…ture/55176-bump-react-fast-pdf

Update PDF.js worker import paths to use legacy version

81b0523

mountiny assigned rezkiy37 Jan 21, 2025

mountiny reviewed Jan 21, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

Move react-native-background-task dependency to the correct path in p…

de4c6ca

…ackage.json

rezkiy37 requested a review from mountiny January 21, 2025 12:51

mountiny approved these changes Jan 21, 2025

View reviewed changes

mountiny merged commit f71f36e into Expensify:main Jan 21, 2025
19 checks passed

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

rezkiy37 mentioned this pull request Jan 24, 2025

Fix Webpack configuration to use the minified pdf.worker file #55743

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump react-fast-pdf #55421

Bump react-fast-pdf #55421

rezkiy37 commented Jan 17, 2025 •

edited

Loading

melvin-bot bot commented Jan 17, 2025

mountiny commented Jan 18, 2025

jjcoffee commented Jan 20, 2025 •

edited

Loading

rezkiy37 commented Jan 20, 2025

jjcoffee commented Jan 20, 2025

jjcoffee commented Jan 20, 2025

rezkiy37 commented Jan 20, 2025 •

edited

Loading

rezkiy37 commented Jan 20, 2025

jjcoffee commented Jan 20, 2025

jjcoffee left a comment

rezkiy37 commented Jan 21, 2025

rezkiy37 commented Jan 21, 2025

mountiny left a comment

mountiny left a comment

OSBotify commented Jan 21, 2025

github-actions bot commented Jan 23, 2025

tgolen commented Jan 24, 2025

tgolen commented Jan 24, 2025

rezkiy37 commented Jan 24, 2025

tgolen commented Jan 24, 2025

rezkiy37 commented Jan 24, 2025

github-actions bot commented Jan 28, 2025

Bump react-fast-pdf #55421

Bump react-fast-pdf #55421

Conversation

rezkiy37 commented Jan 17, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 17, 2025

mountiny commented Jan 18, 2025

jjcoffee commented Jan 20, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

rezkiy37 commented Jan 20, 2025

jjcoffee commented Jan 20, 2025

jjcoffee commented Jan 20, 2025

rezkiy37 commented Jan 20, 2025 • edited Loading

rezkiy37 commented Jan 20, 2025

jjcoffee commented Jan 20, 2025

jjcoffee left a comment

Choose a reason for hiding this comment

rezkiy37 commented Jan 21, 2025

rezkiy37 commented Jan 21, 2025

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 21, 2025

github-actions bot commented Jan 23, 2025

tgolen commented Jan 24, 2025

tgolen commented Jan 24, 2025

rezkiy37 commented Jan 24, 2025

tgolen commented Jan 24, 2025

rezkiy37 commented Jan 24, 2025

github-actions bot commented Jan 28, 2025

rezkiy37 commented Jan 17, 2025 •

edited

Loading

jjcoffee commented Jan 20, 2025 •

edited

Loading

rezkiy37 commented Jan 20, 2025 •

edited

Loading