-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] Add YAPL build step to HybridApp builds #55426
Conversation
npm has a |
674845c
to
4a4faec
Compare
I dm'd Mariusz for a review too. I'm not sure if a separate script is overkill or good practice for keeping these scripts tidy. Let me know what you think! |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Replacing these App changes with a better Gradle fix here: https://github.com/Expensify/Mobile-Expensify/pull/13376 |
Explanation of Change
Engineers building the Android HybridApp for the first time see a failure due to yapl code not being built. They they need to search slack and manually do this which is confusing and time-consuming. This change ensures it is done automatically.
Then I deleted step 3 from the HybridApp build instructions.
I should be able to remove the manual step in our build workflows too, but I'll do that separately.
Fixed Issues
#54877
Tests
A) Script
grunt build: shared
should run when an Android build is startedB) Build
cd app
git submodule update --init --progress --depth 100
npm i
npm run android