-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React Native 0.77 #600
base: main
Are you sure you want to change the base?
Conversation
@@ -132,6 +134,13 @@ android { | |||
} else { | |||
java.srcDirs += ["src/oldarch"] | |||
} | |||
|
|||
// TextLayoutManager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not very informative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...sionPatch/CustomMountingManager/latest/com/expensify/livemarkdown/CustomMountingManager.java
Outdated
Show resolved
Hide resolved
...sionPatch/CustomMountingManager/latest/com/expensify/livemarkdown/CustomMountingManager.java
Show resolved
Hide resolved
@tomekzaw I am confused since this method accepts 3 arguments: https://github.com/facebook/react-native/blob/v0.77.0/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java#L184 and I am giving it 3 arguments: https://github.com/Expensify/react-native-live-markdown/pull/600/files#diff-3557d72e0be2d776fa6982a4f9760a95bcccbedd06e9bbd363707b9d8e8ad83aR109 |
Incorrect component height on Android, 0.77.0, New Arch enabled @j-piasecki said it's probably caused by incorrect order of commit hooks (Markdown & Reanimated). |
Details
PR aligning library with RN 0.77
Related Issues
Commits from RN changing methods used by this library: facebook/react-native@08e8f6a, facebook/react-native@060c594#diff-e53011726a0eaf0dd8acab115a5e380e2b6d5e5e7504e1825bbce8418c1c91cb
Manual Tests
Linked PRs