-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skippable Collection Member IDs #604
Open
fabioh8010
wants to merge
15
commits into
Expensify:main
Choose a base branch
from
callstack-internal:feature/skippable-collection-member-ids
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Skippable Collection Member IDs #604
fabioh8010
wants to merge
15
commits into
Expensify:main
from
callstack-internal:feature/skippable-collection-member-ids
+428
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lection-member-ids
VickyStash
reviewed
Dec 17, 2024
Updates:
|
I've just profiled the Onyx changes -- no significant changes in performance ✅ Profilingmain Onyx branchStartup / Open Big Report
Switch to Big Report
Send Message
Create Expense Flow
skippable member IDs Onyx branchOpen Big Report
Switch to Big Report
Send Message
Create Expense Flow
Reassure
Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
Changes To CountThere are no entries Added ScenariosThere are no entries Removed ScenariosThere are no entries |
fabioh8010
changed the title
[WIP] Skippable Collection Member IDs
Skippable Collection Member IDs
Jan 16, 2025
PR opened to review! |
melvin-bot
bot
requested review from
marcochavezf
and removed request for
a team
January 16, 2025 18:45
VickyStash
reviewed
Jan 17, 2025
VickyStash
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR introduces a new configuration to
Onyx.init()
– the option to specify skippable collection member IDs. It will be possible to pass an array of collection member IDs (strings) which updates will be ignored when using Onyx methods. Additionally, any subscribers from these keys to won't receive any data from Onyx.Example:
Related Issues
Expensify/App#50360
Automated Tests
Unit tests were created to cover the changes.
Manual Tests
General tests in E/App:
Author Checklist
### Related Issues
section aboveTests
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2025-01-16.at.17.44.45-compressed.mov
Android: mWeb Chrome
Screen.Recording.2025-01-16.at.17.49.30-compressed.mov
iOS: Native
Screen.Recording.2025-01-16.at.18.17.09-compressed.mov
iOS: mWeb Safari
Screen.Recording.2025-01-16.at.18.19.00-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2025-01-16.at.18.22.10-compressed.mov
Screen.Recording.2025-01-16.at.18.23.35-compressed.mov
MacOS: Desktop
Screen.Recording.2025-01-16.at.18.27.06-compressed.mov