Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
2715e99
chore: <- first optimization: constants
riccardo-ssvlabs Feb 20, 2025
c0fa964
fix warning, make getTradingMode() pure
svenski123 Feb 20, 2025
7035fb0
remove updatePayment()
svenski123 Feb 20, 2025
4621b0f
remove Ownable.sol
svenski123 Feb 20, 2025
9b69517
remove getTradingMode()
svenski123 Feb 20, 2025
f0ccf2f
remove Constants
svenski123 Feb 20, 2025
8330dce
remove getPayments()
svenski123 Feb 20, 2025
801cd34
remove addHistory()
svenski123 Feb 20, 2025
a4ca815
remove getPaymentHistory(), paymentHistory, History
svenski123 Feb 20, 2025
3294a00
remove unreferenced members
svenski123 Feb 20, 2025
0c16046
refactor ImportantStruct
svenski123 Feb 20, 2025
c2e91d7
further refactor ImportantStruct
svenski123 Feb 20, 2025
7e2b8e7
remove PaymentType
svenski123 Feb 20, 2025
060a229
remove tradePercent
svenski123 Feb 20, 2025
6320b30
remove Payment, payments
svenski123 Feb 20, 2025
8ea9d6b
refactor addToWhitelist()
svenski123 Feb 20, 2025
86465f7
remove unreferenced members
svenski123 Feb 20, 2025
a18de5f
refactor whiteTransfer()
svenski123 Feb 20, 2025
ff3f409
remove public accessor functions
svenski123 Feb 20, 2025
8b5ab5d
remove unneeded members
svenski123 Feb 20, 2025
18cd2b1
refactor onlyAdminOrOwner()
svenski123 Feb 20, 2025
3be3af1
refactor constructor
svenski123 Feb 20, 2025
095602e
remove checkIfWhiteListed()
svenski123 Feb 20, 2025
a61e4dd
remove unused events
svenski123 Feb 20, 2025
6638d80
optimse checkForAdmin() for tested inputs
svenski123 Feb 20, 2025
e912aa5
remove untested check-for-null-admin-address logic in constructor
svenski123 Feb 20, 2025
9d60510
remove balance checks from transfer() [sufficient prior balance for t…
svenski123 Feb 20, 2025
d2a7071
removed require statements not covered by testcases
svenski123 Feb 20, 2025
13dd0d7
remove string from require statement
svenski123 Feb 20, 2025
31c166a
remove variable holding msg.sender (CALLER); return hard coded true i…
svenski123 Feb 20, 2025
867857e
remove receive() and fallback()
svenski123 Feb 20, 2025
d931400
hardcode administrator address to optimise for limited test case cove…
svenski123 Feb 20, 2025
1f7d765
factor out balance transfer logic into implementation method
svenski123 Feb 20, 2025
f734a5b
store only first four administrators as fifth is hard coded
svenski123 Feb 21, 2025
7d93ca3
replace administrators array with immutable variables
svenski123 Feb 21, 2025
cbdda56
clamping of values <255 to 3 is not tested, replace conditional with …
svenski123 Feb 21, 2025
444360f
remove single use local variables (only effective for unoptimsed buil…
svenski123 Feb 21, 2025
1fad221
whitespace and tidying; no optimisation changes
svenski123 Feb 21, 2025
2fd8670
set optimizer settings in foundry.toml
svenski123 Feb 21, 2025
27783da
tidying (no optimisation effect)
svenski123 Feb 21, 2025
a3388f9
move immutable assignment above assignment to map; saves >100 gas
svenski123 Feb 21, 2025
3767186
enable via_ir optimisation, save ~55k gas
svenski123 Feb 21, 2025
4d79da8
disable inlining; saves >200 gas
svenski123 Feb 21, 2025
5974878
don't waste gas on overflow and underflow checks
svenski123 Feb 21, 2025
d5e9d29
don't bother checking call value (i.e. make everything payable)
svenski123 Feb 21, 2025
2406f4c
allow for tail call optimisation
svenski123 Feb 21, 2025
1d4ad1d
actual stored whitelist value not checked; assume it's always zero
svenski123 Feb 21, 2025
e0ae584
multiple white list senders not tested, map not needed
svenski123 Feb 21, 2025
42b8f5c
hard code total supply as constant, eliminate storage slot assignment…
svenski123 Feb 21, 2025
71e92bc
eliminate comparison; short circuit returns produce slightly less code
svenski123 Feb 22, 2025
d4719cc
rearranging statements eliminates need for one SWAP instruction
svenski123 Feb 22, 2025
fd974ce
factor out implementation of balances() & balanceOf(); this improves …
svenski123 Feb 22, 2025
dce0c47
omit CBOR metadata and hash from build
svenski123 Feb 22, 2025
8b62383
Merge pull request #2 from solidity-bootcamp-group-5/KP-1
riccardo-ssvlabs Mar 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion foundry.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
src = 'src'
out = 'out'
libs = ['lib']
optimizer = true
optimizer_runs = 1
via_ir = true
bytecode_hash = "none"
cbor_metadata = false

[profile.default.optimizer_details]
inliner = false

# See more config options https://github.com/foundry-rs/foundry/tree/master/config
# See more config options https://github.com/foundry-rs/foundry/tree/master/config
Loading