Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R8_UNORM and R16_UNORM extended surface formats #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kg
Copy link
Contributor

@kg kg commented Dec 24, 2024

Tested on OpenGL, D3D11 and SDL_GPU.

@kg
Copy link
Contributor Author

kg commented Dec 24, 2024

You may ask "Why do we need R8_UNORM when Alpha8 exists?" And the answer is that Alpha8 behaves differently on each backend right now, but R8_UNORM as Red is consistent.

@flibitijibibo
Copy link
Member

If the behavior is different that's likely a bug, unless the APIs define them differently - I would definitely prefer bugs first and extensions dead last, rather than the other way around.

@kg
Copy link
Contributor Author

kg commented Dec 25, 2024

I looked into fixing Alpha8 before and couldn't figure it out. I'd be happy to pair with someone who wants to look into it I guess? It's also a problem in that Alpha8 RTs don't work in GL, while R8/R16 ones do.

@flibitijibibo
Copy link
Member

Blocked by MoonsideGames/dav1dfile#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants