Add --merge-config flag to support merging with default configuration #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fairwinds Insights Scan ResultsView the full report at insights.fairwinds.com. ✅ No new Action Items detected! |
2 tasks
|
We would really like to try this out in our client-side validation stack. Any chance this can be reviewed and merged 🙏 |
vitorvezani
changed the title
sudermanjr
requested changes
Oct 21, 2024
Co-authored-by: Andy Suderman <[email protected]>
jdesouza
approved these changes
Oct 22, 2024
sudermanjr
approved these changes
Oct 22, 2024
|
Thanks, this is awesome 😃 Testing it straight away 🚀 EDIT: It just works. Thanks again 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #910
Checklist
Description
What's the goal of this PR?
This PR introduces a new Polaris flag,
--merge-config(-m), which allows merging user-provided configurations with the default settings, instead of fully overriding them. This provides greater flexibility by retaining default values for unspecified settings, ensuring smoother configuration management.What changes did you make?
ParseFilefunction is nowMergeConfigAndParseFileWhat alternative solution should we consider, if any?