Skip to content

Commit

Permalink
Publish 5.26.1.
Browse files Browse the repository at this point in the history
  • Loading branch information
bgrainger committed Feb 14, 2025
1 parent 8104bee commit 755cfc0
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
4 changes: 2 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<Project>

<PropertyGroup>
<VersionPrefix>5.26.0</VersionPrefix>
<PackageValidationBaselineVersion>5.21.0</PackageValidationBaselineVersion>
<VersionPrefix>5.26.1</VersionPrefix>
<PackageValidationBaselineVersion>5.26.0</PackageValidationBaselineVersion>
<LangVersion>12.0</LangVersion>
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
Expand Down
5 changes: 5 additions & 0 deletions ReleaseNotes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Release Notes

## 5.26.1

* Switch from `dotnet sign` to Faithlife.SignTool for package signing.
* `dotnet sign` was not detecting the Azure credentials obtained by Actions/az-login.

## 5.26.0

* Allow NuGet packages to be signed before publishing by setting `PackageSettings.SigningSettings`: [#70](https://github.com/Faithlife/FaithlifeBuild/pull/70).
Expand Down
4 changes: 2 additions & 2 deletions src/Faithlife.Build/DotNetBuild.cs
Original file line number Diff line number Diff line change
Expand Up @@ -566,15 +566,15 @@ string[] GetTargetFrameworks()
}

// install dotnet sign
RunDotNet("tool", "install", "--tool-path", "release/sign", "--prerelease", "sign");
RunDotNet("tool", "install", "--tool-path", "release/sign", "--prerelease", "Faithlife.SignTool");
}

foreach (var packagePath in packagePaths)
{
if (signingArguments is not null)
{
// sign the package before it's published; this will unzip it, sign each file it contains, rezip it, then sign the package as a whole
RunApp("release/sign/sign", [.. signingArguments, packagePath]);
RunApp("release/sign/faithlife-sign", [.. signingArguments, packagePath]);
}

var pushArgs = new[]
Expand Down

0 comments on commit 755cfc0

Please sign in to comment.