fix(Messaging): Fix memory leak on unsubscribe

Famcache · Jun 18, 2024 · b0075ac · b0075ac
1 parent 85327c8
commit b0075ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -93,7 +93,7 @@ client.messaging.subscribe('topic', (data) => {
 ```
 
 #### Unsubscribe from the topic
-
+  
 To unsubscribe from the topic:
 ```ts
 client.messaging.unsubscribe('topic');

diff --git a/src/modules/messaging.ts b/src/modules/messaging.ts
@@ -40,6 +40,8 @@ export class Messaging implements IMessaging {
         const queryId = this.genId();
 
         this.socket.write(unsubscribe(queryId, topic));
+
+        this.listeners.delete(topic);
     }
 
     trigger(message: MessagingEvent) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -93,7 +93,7 @@ client.messaging.subscribe('topic', (data) => { @@
     ```
     #### Unsubscribe from the topic
     To unsubscribe from the topic:
     ```ts
     client.messaging.unsubscribe('topic');
@@ Expand Down @@