Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add num_rounds and num_chips to poker envs #1109
Add num_rounds and num_chips to poker envs #1109
Changes from 19 commits
fad28c3
ee51fb4
f0cd4b2
4f6545d
02cf1d6
d4e2028
4e06b0f
cb9671c
53d15fd
93036cb
96cfac9
88817b1
1fd262e
8506bdc
c53b8df
77de93e
e58ccb6
a273289
cb1825a
e3520ee
2370135
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an interesting way to do it, but I'm not sure if this is the best name for it. Can't really think of anything else besides
starting_reward
or something. Maybe it could be liketotal_rewards
to indicate that it makes the rewards track between resets. Ortally_rewards
. Feel likestarting_utility
doesn't mean anything to me if I don't know how it works. Would make sense and be simple if it wastotal_rewards
adds or subtracts by round.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think utility makes more sense, this is a pretty standard way of saying "starting amount of meaningful substance", starting reward can be confused for the reward given to the agent for starting a new episode, while tally rewards sounds like it should be a boolean.