Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation testing #1118

Closed
wants to merge 2 commits into from

Conversation

elliottower
Copy link
Contributor

This is just a test to see if this will execute faster than the pytest plugin which we previously used, and took 30 minutes even with ten instances. On my laptop it seemed to run pretty fast, so we'll see if it improves CI time.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue), Depends on # (pull request)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.
To upload images to a PR -- simply drag and drop or copy paste.

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@elliottower
Copy link
Contributor Author

This passed entirely locally so I'm a little confused why it failed here, I guess maybe something with pytest split

@elliottower
Copy link
Contributor Author

We did some experiments in Minari and Omar was able to get a good workflow with this package as well as another one for running bash scripts and other commands, I think this PR will probably be closed in favor of something like that (but I don't have much time to get around to it, the current CI works albeit with a lot of compute)

@elliottower
Copy link
Contributor Author

Going to close this for now, maybe will fix in the future to be more like minari but it's probably fine for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant