Fix bug in SB3 tutorial ActionMask #1203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SB3ActionMaskWrapper.step() is intended to be compatible with Gymnansium's
interface where step() returns observation, reward, termination, truncation, info
This was implemented using the last() function. But this returns the values for
the current agent, not the agent that just acted as Gymnasium would.
Among other things, this trains on the opponent's reward, encouraging bad play.
The function now returns the reward, termination, truncation, info values for the
agent that just acted. It still returns the observation for the next agent since
it is used to determine the next action.
Fixes #1147
Type of change
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)pytest -v
and no errors are present.pytest -v
has generated that are related to my code to the best of my knowledge.