Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #1242 bug report broken tests for connect four in ci #1243

Merged

Conversation

David-GERARD
Copy link
Collaborator

Description

Fixes #1242

The sb3 tutorial for connect_four breaks for versions of gymnasium>0.29.1, which makes the CI for all PR fail.
This PR is a temporary fix until a more permanent solution is found.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes

  • Removed SB3/connect_four from the tests in workflow .github/workflows/linux-tutorials-test.yml.
  • Added a check for the versions of gymnasium in tutorials/SB3/connect_four/sb3_connect_four_action_mask.py that throws ImportError if gymnasium>0.29.1.
  • Added a warning in the docs that the tutorial breaks for gymnasium>0.29.1 in docs/tutorials/sb3/connect_four.md

Checklist:

  • I have run the pre-commit checks with pre-commit run --all-files (see CONTRIBUTING.md instructions to set it up)
  • I have run pytest -v and no errors are present.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I solved any possible warnings that pytest -v has generated that are related to my code to the best of my knowledge.
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@David-GERARD David-GERARD added the bug Something isn't working label Nov 24, 2024
@David-GERARD David-GERARD self-assigned this Nov 24, 2024
@David-GERARD David-GERARD linked an issue Nov 24, 2024 that may be closed by this pull request
@David-GERARD David-GERARD marked this pull request as draft November 24, 2024 20:54
@David-GERARD David-GERARD marked this pull request as ready for review November 24, 2024 20:56
@David-GERARD David-GERARD requested review from mwydmuch and removed request for jkterry1 November 24, 2024 21:25
@jkterry1 jkterry1 merged commit c1260f7 into master Dec 2, 2024
43 checks passed
@David-GERARD David-GERARD deleted the 1242-bug-report-broken-tests-for-connect_four-in-ci branch December 3, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] broken tests for connect_four in CI
2 participants