Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vim.md - fixing arrow head positions for left-right motions #624

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qwertyqwerty223
Copy link

@qwertyqwerty223 qwertyqwerty223 commented Dec 20, 2024

attempted to reformat the arrow lines indicating the left-right motions by readjusting the arrowheads to match their appropriate lines and positions.

I have attempted to reformat the arrow lines indicating the left-right motions by readjusting the arrowheads to match their appropriate lines and positions.
@qwertyqwerty223 qwertyqwerty223 marked this pull request as draft December 20, 2024 22:08
@qwertyqwerty223 qwertyqwerty223 marked this pull request as ready for review December 20, 2024 22:08
@Fechin
Copy link
Owner

Fechin commented Dec 23, 2024

Hey there! Thanks for taking the time to submit this PR. I really appreciate you trying to help improve the documentation! 👋 Just wanted to let you know that the original arrow positions were actually correct - they were showing Vim's directional movements properly.

@qwertyqwerty223
Copy link
Author

qwertyqwerty223 commented Dec 23, 2024

@Fechin Thanks for reviewing my PR! The arrow positions do show up properly when I access the webpage in the Safari browser on my iPhone 15:
Vim-Cheat-Sheet-Quick-Reference-mobile

However, they are not aligned properly when I access the webpage via Firefox ESR on Debian:
Vim-Cheat-Sheet-Quick-Reference-Laptop

@Fechin
Copy link
Owner

Fechin commented Dec 24, 2024

Hey @qwertyqwerty223, thanks for the detailed feedback and showing the browser differences! It's really helpful to see how it looks on both Safari and Firefox ESR. Have you had a chance to test it out in other browsers like Chrome or Edge? Would be awesome if we could get this working nicely across all browsers! 🙌

@qwertyqwerty223
Copy link
Author

qwertyqwerty223 commented Dec 24, 2024

Yes. I accessed the webpage across multiple browsers on my desktop (Windows 10), but the arrow positions are still not properly aligned. Here are the images for for reference:

Microsoft Edge:

image

Google Chrome:

image

Firefox (Latest stable release):

image

Brave browser:

image

As for browsers on mobile, the arrow formatting does show properly for browsers on iPhone, but that is not the case for android browsers.

@yiiman-dev
Copy link
Contributor

I will examine this issue on Android browsers and report the results or any changes to resolve the problem.

@yiiman-dev
Copy link
Contributor

Screenshot_2024-12-27-15-27-44-014_com.microsoft.emmx.canary.jpg

Has problem on android

yiiman-dev added a commit to yiiman-dev/reference that referenced this pull request Dec 27, 2024
yiiman-dev added a commit to yiiman-dev/reference that referenced this pull request Dec 27, 2024
@yiiman-dev
Copy link
Contributor

I commited some changes
Now changed arrange of numbers and arrows to fit better on mobile, but has few problems on android.
Screenshot_2024-12-28-01-01-03-494_com.microsoft.emmx.canary.jpg

What do you think? @Fechin
Need any change? or rollback?

@yiiman-dev
Copy link
Contributor

yiiman-dev commented Dec 27, 2024

the right side has scrollbar
Screenshot_2024-12-28-01-04-27-336_com.microsoft.emmx.canary.jpg
You can check new changes here:
https://snippet.yiiman.ir/vim.html

@yiiman-dev
Copy link
Contributor

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants