Example of using DelaunayTriangulation.jl for mesh generation #1040
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
=======================================
Coverage 93.74% 93.74%
=======================================
Files 39 39
Lines 6238 6238
=======================================
Hits 5848 5848
Misses 390 390 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
docs/src/literate-howto/delaunay.jl
Outdated
| # The solution can be visualised as in previous tutorials. Alternatively, we can use `tricontourf` which | ||
| # knows how to use DelaunayTriangulation.jl's `Triangulation`. | ||
| sol = evaluate_at_grid_nodes(dh, u, :u) | ||
| tricontourf(tri, sol) |
There was a problem hiding this comment.
IMHO it would be advantageous to plot with FerriteViz
There was a problem hiding this comment.
I wanted to do that originally but didn't because it doesn't work on Ferrite master. I could dev in Ferrite-FEM/FerriteViz.jl#103 to make it work?
There was a problem hiding this comment.
thats fine in my opinion but ping @KnutAM @termi-official @fredrikekre
There was a problem hiding this comment.
Seems like a good idea to too!
The only downside I see, is that it requires that branch to be continuously kept up to date with Ferrite#master changes now in the time before releasing. But not sure how hard / much work that is?
There was a problem hiding this comment.
I agree with Maxi, but let us do this after 1.0 release, so we can make a FerriteViz release instead of relying on me keeping the FerriteViz branch up to date.
There was a problem hiding this comment.
I guess this is just waiting on FerriteViz to be made compatible with Ferrite 1.0 before reviewing further?
There was a problem hiding this comment.
Right. The release is already in review, so we should be able to update FerriteViz to 1.0 in the not too far future.
There was a problem hiding this comment.
You might be wondering, but we are still preparing the release. Several new "bugs" appeared in FerriteViz which block the release.
There was a problem hiding this comment.
Should we just proceed with Plots jl for now and add some message to not delay this further @koehlerson ?
|
I've addressed the review comments from @KnutAM. Let me know if there's anything else. |
|
Have I forgotten anything here? Seems fine for me locally, but I'm waiting to see the workflows |
Sorry that I didn't press the button to re-run the workflows. Seems like some formatting issues are detected (probably due to spaces at the end of lines). Unfortunately, I don't have time to check the docs locally right now, but maybe someone else can check and approve (again)? |
Closes #975
Wasn't too sure where to put the example, so I just put in the howto section.
I explain some things that are also explained in more detail in DelaunayTriangulation.jl's docs since I wanted to
try to make this example somewhat self-contained, but I give links to my docs for more information. The mesh refinement here is pretty simple, but I note in the explanation that it could be easily adapted for things like graded meshes or adaptive refinement.