feat: support review apps #799
Conversation
rowanmanning
force-pushed
the
hako-review-apps
branch
from
55367a5 to
275b320
Compare
This adds in an option to run hako deploy with an "ephemeral" app, which is a similar concept to Heroku review apps. To make this work we need to pass Hako config into the Docker command as STDIN. This also updates the two wrapper plugins to introduce a `deploy:review` command. This was all tested locally in cp-docker-migration-canary. It works aside from an issue with name length, we're talking to Cloud Enablement about this. Co-Authored-By: Alex Muller <[email protected]>
rowanmanning
force-pushed
the
hako-review-apps
branch
from
275b320 to
ad5a0d4
Compare
| throw new Error(`Hako config not found at ${hakoConfigPath}`) | ||
| } | ||
| } | ||
| child.stdin.end() |
There was a problem hiding this comment.
praise: beautifully done
| // Because we can't mount volumes in Docker images on CircleCI we have to | ||
| // pass the hako config via STDIN |
There was a problem hiding this comment.
question: why can't we include the hako-config file in the Docker build context instead of passing it in at runtime?
There was a problem hiding this comment.
Because of this, Docker is incapable of mounting volumes (and thus reading files) in CircleCI unless you use a machine executor which would require us to make a lot of CircleCI config changes.
More detail here, sorry I should have linked this.
There was a problem hiding this comment.
Oh wait that wasn't what you were asking. Because the docker run in question is Hako, not the image we built
There was a problem hiding this comment.
Sorry, I mean why can't we include the hako-config/apps/.../app.yaml file in the Docker image we build in the DockerBuild task – but the answer is because we're running the hako image here not the image we've built (edit: like you say) 😰 This approach makes sense then (though I hope we'll get to a point where Hako doesn't (officially) require Docker some day)
There was a problem hiding this comment.
Yeah I'd like that too 😂 would simplify some things but I'm sure introduce some fun different issues. The stdin stuff was also a big pain for Cloud Enablement to implement
Description
This adds in an option to run hako deploy with an "ephemeral" app, which is a similar concept to Heroku review apps. To make this work we need to pass Hako config into the Docker command as STDIN.
This also updates the two wrapper plugins to introduce a
deploy:reviewcommand.This was all tested locally in cp-docker-migration-canary. It works
aside from an issue with name length, we're talking to Cloud Enablement about thisfixedThis relies on https://github.com/Financial-Times/hako-cli/pull/324
Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too