Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apphosting dir fixes #121

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Apphosting dir fixes #121

merged 5 commits into from
Nov 29, 2023

Conversation

jamesdaniels
Copy link
Collaborator

@jamesdaniels jamesdaniels commented Nov 29, 2023 •
edited
Loading

  • For standalone and no CDN static directory should be placed in .next (see docs here)
  • Public dir existence check was looking at the wrong spot
  • Use relative directories in the bundle.yaml
  • Fix the race conditions in the folder moving which were wiping files out

@jamesdaniels jamesdaniels requested a review from sjjj986 November 29, 2023 17:40
@sjjj986 sjjj986 merged commit 68c8e99 into main Nov 29, 2023
9 checks passed
@sjjj986 sjjj986 deleted the apphosting_dir_fixes branch November 29, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjjj986 sjjj986 sjjj986 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesdaniels @sjjj986