-
-
Notifications
You must be signed in to change notification settings - Fork 242
Allow specifying exactly what type of database string is expected in the database section for trace configuration #8427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, avoid massive not related changes such as end space trimming.
It makes harder to read the patch looking for valuable changes.
Consider Note, in proposed syntax Also, your sample is wrong as default section must be the first one. |
Sorry, my IDE automatically trimmed the spaces and didn't display them in the DIFF editor |
Now databaseName and databaseRegex are used
|
Co-authored-by: Vlad Khorsun <[email protected]>
If we try to run trace with following config:
-- then on 6.0.0.710-f54cd06 we will get: Error creating trace session for service manager attachment: But in fbtrace.conf there is comment: So, what is the proper name of section related to services - should it be specified in the singular or plural form ? |
The correct term is "services." I misspelled it, but I'll prepare a PR to fix it. |
What's the difference between them ? (i.e. for what one more section was introduced - just for ease of perception when read trace config ?) |
This change is a solution to a problem when there is a database that has a correct path but the path is an incorrect regex: #8426 |
The new syntax:
I chose
database = name path.fdb
overdatabase name = path.fdb
because it is easier to implement and parse, but it doesn't look as great, so it can be reimplemented.