-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
260 refactor pass tuple types as a result from expressionbuilder not via the typemanager #523
Merged
baseTwo
merged 28 commits into
develop-2.0
from
260-refactor---pass-tuple-types-as-a-result-from-expressionbuilder-not-via-the-typemanager
Sep 11, 2024
Merged
260 refactor pass tuple types as a result from expressionbuilder not via the typemanager #523
baseTwo
merged 28 commits into
develop-2.0
from
260-refactor---pass-tuple-types-as-a-result-from-expressionbuilder-not-via-the-typemanager
Sep 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…result-from-expressionbuilder-not-via-the-typemanager
…sionbuilder-not-via-the-typemanager' of https://github.com/FirelyTeam/firely-cql-sdk into 260-refactor---pass-tuple-types-as-a-result-from-expressionbuilder-not-via-the-typemanager
…result-from-expressionbuilder-not-via-the-typemanager
…sionbuilder-not-via-the-typemanager' of https://github.com/FirelyTeam/firely-cql-sdk into 260-refactor---pass-tuple-types-as-a-result-from-expressionbuilder-not-via-the-typemanager
ewoutkramer
approved these changes
Sep 11, 2024
baseTwo
deleted the
260-refactor---pass-tuple-types-as-a-result-from-expressionbuilder-not-via-the-typemanager
branch
September 11, 2024 12:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work for #260
TypeManager
did not have a single responsibility, so determined that it's sole purpose was to create and cache dynamic tuples. It included a dependency onTypeResolver
, which it didn't use itself. This was removed, if a service needsTypeResolver
, they must include it directly (see change inAssemblyCompiler
)TypeManager
was renamed toTupleBuilderCache
.It is likely that the tuple build cache must not be re-used over librarysets, therefore its lifetime was changed to scoped. This also affects the expression builders and pipeline services to be scoped.
Additional
*ExpressionBuilderContext
types and removing the internal fields from the*ExpressionBuilder
types. Opt to create factory methods for contexts from the builders instead.*ExpressionBuilderContext
, instead injecting the actual context.Program.cs
file into separate initializers. Similar to the service initializers in the other projects, but additionally including configuration, logging, and commandline switches as wellCQL SDK Service Dependencies
Remarks