feat: Add GIN index on Identity.identifier
#5369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
github-actions
bot
added
api
Docker builds report
|
|
Uffizzi Preview |
github-actions
bot
added
feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5369 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 1234 1235 +1
Lines 43299 43326 +27
=======================================
+ Hits 42282 42309 +27
Misses 1017 1017 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gagantrivedi
requested changes
May 8, 2025
| indexes = [ | ||
| UnrestrictedGinIndex( | ||
| OpClass(Upper("identifier"), name="gin_trgm_ops"), | ||
| name="environments_identity_identifier_gin_idx", |
There was a problem hiding this comment.
Nit: Can we shorten the index name to just identifier_gin_idx to avoid having to subclass? It's not immediately clear what UnrestrictedGinIndex means just from the class name. If we do keep that class, could we add a docstring to explain its purpose?
gagantrivedi
reviewed
May 8, 2025
api/environments/identities/migrations/0003_add_idenity_identifier_gin_index.py
Outdated
Show resolved
Hide resolved
khvn26
force-pushed
the
feat/add-identity-identifier-index
branch
from
ad431e7 to
1c5aa22
Compare
github-actions
bot
added
feature
github-actions
bot
added
feature
khvn26
force-pushed
the
feat/add-identity-identifier-index
branch
from
55e03db to
5424560
Compare
github-actions
bot
added
feature
khvn26
force-pushed
the
feat/add-identity-identifier-index
branch
from
5424560 to
0a0bd88
Compare
github-actions
bot
added
feature
gagantrivedi
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
This PR improves
/api/v1/environments/{environment_api_key}/identities/when searching through large quantities of identities.How did you test this code?
Made sure the migration works as expected locally.
The index has been tested in staging and is working in prod for one of the enterprise customers.