Cleanup: Formatting, Type Safety & Annotations, Deduplications #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption chain with 'from err'
…es.py Refactored error classes in errors.py to import the ApiError data class from types.py instead of redefining it. This change eliminates code duplication and ensures a single source of truth for the ApiError definition.
Add comprehensive type annotations to constants and collections throughout const.py: - Import and use Platform enum from homeassistant.const instead of string literals - Add proper type hints for all sensor lists and mappings - Use Final from typing module to ensure constants remain immutable - Maintain specific type imports from types.py for domain-specific types These changes improve type safety, IDE autocompletion, and static analysis capabilities without modifying actual functionality.
- Add proper type annotations for collections (list, dict) in const.py - Import specific type definitions from types.py (DataSectionType, TimezoneType, UnitSystemType) - Use inline type annotations for standard collections - Fix missing type annotation on OCEAN_CURRENT_SENSORS - Improve code readability and type safety for static analysis
… type definitions - Add a new CompositeSensorGroupsType TypedDict for defining relationships between composite sensors such as wind and current measurements - Ensure the ApiError dataclass is properly defined for centralized error handling across the integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.