Ignore E402 (import not at the top of file) in pre-commits (apache#35873

)

Pre-commits often import some modules from elsewhere after inserting
a common folder at PYTHONPATH. Pre-commits are pretty special,
because they are supposed to be run as standalone scripts
by pre-commit framework as git hooks, and they often do
similar things, so some common code in pre-commits is good to have.

Ignoring E402 error in all pre-commits seems like best way to
avoid unnecessary individual exclusions.

pyproject.toml

@@ -140,6 +140,7 @@ combine-as-imports = true
 
 # All of the modules which have an extra license header (i.e. that we copy from another project) need to
 # ignore E402 -- module level import not at top level
+"scripts/ci/pre_commit/*.py" = ["E402"]
 "airflow/api/auth/backend/kerberos_auth.py" = ["E402"]
 "airflow/security/kerberos.py" = ["E402"]
 "airflow/security/utils.py" = ["E402"]

scripts/ci/pre_commit/common_precommit_black_utils.py

@@ -25,7 +25,7 @@
 
 sys.path.insert(0, str(Path(__file__).parent.resolve()))  # make sure common_precommit_utils is imported
 
-from common_precommit_utils import AIRFLOW_BREEZE_SOURCES_PATH  # isort: skip # noqa E402
+from common_precommit_utils import AIRFLOW_BREEZE_SOURCES_PATH
 
 
 @lru_cache(maxsize=None)

scripts/ci/pre_commit/pre_commit_check_pre_commit_hooks.py

@@ -26,19 +26,18 @@
 from pathlib import Path
 
 sys.path.insert(0, str(Path(__file__).parent.resolve()))  # make sure common_precommit_utils is imported
-from common_precommit_utils import (  # isort: skip # noqa: E402
+from collections import defaultdict
+from typing import Any
+
+import yaml
+from common_precommit_black_utils import black_format
+from common_precommit_utils import (
     AIRFLOW_BREEZE_SOURCES_PATH,
     AIRFLOW_SOURCES_ROOT_PATH,
     insert_documentation,
 )
-from common_precommit_black_utils import black_format  # isort: skip # noqa E402
-
-from collections import defaultdict  # noqa: E402
-from typing import Any  # noqa: E402
-
-import yaml  # noqa: E402
-from rich.console import Console  # noqa: E402
-from tabulate import tabulate  # noqa: E402
+from rich.console import Console
+from tabulate import tabulate
 
 console = Console(width=400, color_system="standard")
 

scripts/ci/pre_commit/pre_commit_check_setup_extra_packages_ref.py

@@ -39,12 +39,12 @@
 
 os.environ["_SKIP_PYTHON_VERSION_CHECK"] = "true"
 
-from setup import (  # noqa # isort:skip
-    add_all_provider_packages,
-    EXTRAS_DEPRECATED_ALIASES,
+from setup import (
     EXTRAS_DEPENDENCIES,
-    PREINSTALLED_PROVIDERS,
+    EXTRAS_DEPRECATED_ALIASES,
     EXTRAS_DEPRECATED_ALIASES_IGNORED_FROM_REF_DOCS,
+    PREINSTALLED_PROVIDERS,
+    add_all_provider_packages,
 )
 
 

scripts/ci/pre_commit/pre_commit_compile_www_assets.py

@@ -23,7 +23,7 @@
 from pathlib import Path
 
 sys.path.insert(0, str(Path(__file__).parent.resolve()))  # make sure common_precommit_utils is imported
-from common_precommit_utils import get_directory_hash  # isort: skip # noqa E402
+from common_precommit_utils import get_directory_hash
 
 AIRFLOW_SOURCES_PATH = Path(__file__).parents[3].resolve()
 WWW_HASH_FILE = AIRFLOW_SOURCES_PATH / ".build" / "www" / "hash.txt"

scripts/ci/pre_commit/pre_commit_insert_extras.py

@@ -30,8 +30,9 @@
 
 os.environ["_SKIP_PYTHON_VERSION_CHECK"] = "true"
 
-from common_precommit_utils import insert_documentation  # isort: skip  # noqa: E402
-from setup import EXTRAS_DEPENDENCIES  # isort:skip  # noqa: E402
+from common_precommit_utils import insert_documentation
+
+from setup import EXTRAS_DEPENDENCIES
 
 sys.path.append(str(AIRFLOW_SOURCES_DIR))
 

scripts/ci/pre_commit/pre_commit_update_common_sql_api_stubs.py

@@ -36,8 +36,8 @@
 
 sys.path.insert(0, str(Path(__file__).parent.resolve()))  # make sure common_precommit_utils is imported
 
-from common_precommit_utils import AIRFLOW_SOURCES_ROOT_PATH  # isort: skip # noqa E402
-from common_precommit_black_utils import black_format  # isort: skip # noqa E402
+from common_precommit_black_utils import black_format
+from common_precommit_utils import AIRFLOW_SOURCES_ROOT_PATH
 
 PROVIDERS_ROOT = AIRFLOW_SOURCES_ROOT_PATH / "providers"
 COMMON_SQL_ROOT = PROVIDERS_ROOT / "common" / "sql"

scripts/ci/pre_commit/pre_commit_update_versions.py

@@ -23,7 +23,7 @@
 
 sys.path.insert(0, str(Path(__file__).parent.resolve()))  # make sure common_precommit_utils is importable
 
-from common_precommit_utils import AIRFLOW_SOURCES_ROOT_PATH, read_airflow_version  # noqa: E402
+from common_precommit_utils import AIRFLOW_SOURCES_ROOT_PATH, read_airflow_version
 
 
 def update_version(pattern: re.Pattern, v: str, file_path: Path):