Skip to content

Update glass_hover_effect.dart #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update glass_hover_effect.dart #2

wants to merge 2 commits into from

Conversation

the-lastbit
Copy link

Add fix for rounded corners in the BackDropFilter widget

@the-lastbit
Update glass_hover_effect.dart
a529de2 
Add fix for rounded corners in the BackDropFilter
@md-weber md-weber self-requested a review September 22, 2023 08:15
md-weber
md-weber requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@md-weber md-weber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, thanks for your contribution!
I tested it quickly and saw that you fixed on thing but you introduced another bug. Now the text is always visible on the screen.

image

@the-lastbit
Update glass_hover_effect.dart
5ce63d5 
Sorry man, I didn't see the message about my mistake, forgot to wrap the SizedBox with another ClipRect because I was debugging in a phone and the narrow screen didn't show the text in the right side 😅, But now it works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@md-weber md-weber md-weber requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-lastbit @md-weber