-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Server-To-Client handler #152
base: master
Are you sure you want to change the base?
Conversation
Hi @vduduh, many thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
You did it @vduduh! Thank you for signing the ProcessOne Contribution License Agreement. We will have a look at your contribution! |
Hello vduduh and thanks for contributing !
Also, as the spec that you linked says, the client must only respond if it supports the ping namespace. For now, there is no way for the client to say that it supports this feature because responding to IQ requests is not supported (also, we don't support it). We would need to implement that first. If you'd like to have a go at it, that'd be great ! :) |
Hello @remicorniere ! |
I understand. Thank you for suggesting this change. Although for now I believe the code edits were not made in the right place (see my previous comment). For now I will link this PR to an issue reflecting your feature request. |
https://xmpp.org/extensions/xep-0199.html#s2c