Merge pull request #380 from moshie/fix-default-props

Remove Default props
FormidableLabs · Feb 2, 2024 · 22e348e · 22e348e
2 parents 8efde89 + de346d7
commit 22e348e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/.changeset/popular-pumas-beam.md b/.changeset/popular-pumas-beam.md
@@ -0,0 +1,5 @@
+---
+"react-live": patch
+---
+
+fix default props
diff --git a/packages/react-live/src/components/Editor/index.tsx b/packages/react-live/src/components/Editor/index.tsx
@@ -15,6 +15,7 @@ export type Props = {
 };
 
 const CodeEditor = (props: Props) => {
+  const { tabMode = "indentation" } = props;
   const editorRef = useRef(null);
   const [code, setCode] = useState(props.code || "");
   const { theme } = props;
@@ -25,7 +26,7 @@ const CodeEditor = (props: Props) => {
 
   useEditable(editorRef, (text) => setCode(text.slice(0, -1)), {
     disabled: props.disabled,
-    indentation: props.tabMode === "indentation" ? 2 : undefined,
+    indentation: tabMode === "indentation" ? 2 : undefined,
   });
 
   useEffect(() => {
@@ -81,8 +82,4 @@ const CodeEditor = (props: Props) => {
   );
 };
 
-CodeEditor.defaultProps = {
-  tabMode: "indentation",
-} as Pick<Props, "tabMode">;
-
 export default CodeEditor;