Skip to content

Commit

Permalink
Update guidelines regarding dependency/build-config updates
Browse files Browse the repository at this point in the history
  • Loading branch information
naveensingh authored Jan 24, 2025
1 parent cf59a85 commit d961f81
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ A place for discussing all apps in general + anything else you want to say.
6. Always use brackets, even at 1 liner "if", "return" or "continue" statements, etc.
7. If you add a new model or work with Gson, test the build in release mode with Proguard enabled as well.
8. There is no real functionality change between build flavors, only some About button visibility differences, Rate Us dialog, and More Apps From Us buttons not showing up or so.

If you try fixing a bug or adding a new feature, make sure that it is already reported at the given repository and the report is open without label `needs triage`. If the given issue is closed or still has `needs triage` label, your pull request will likely be rejected. The only exceptions are critical bugs that we weren't able to classify yet.
9. Before fixing a bug or adding a new feature, ensure it’s already reported or requested in the repository, open, and doesn’t have the `needs triage` label. If the issue is closed or has `needs triage` label, your PR will likely be rejected. The only exceptions are critical bugs that we weren't able to classify yet.
10. PRs altering build configuration, dependencies or SDK updates won't be accepted unless explicitly requested.

---

Expand Down

0 comments on commit d961f81

Please sign in to comment.