Throw S3FileStorageException when something goes wrong and response is not as expected.

src/Foundatio.AWS/Storage/S3FileStorage.cs

@@ -11,6 +11,7 @@
 using Amazon.S3.Model;
 using Amazon.S3.Util;
 using Foundatio.AWS.Extensions;
+using Foundatio.AWS.Storage;
 using Foundatio.Extensions;
 using Foundatio.Serializer;
 using Microsoft.Extensions.Logging;
@@ -54,7 +55,7 @@ public S3FileStorage(Builder<S3FileStorageOptionsBuilder, S3FileStorageOptions>
             : this(builder(new S3FileStorageOptionsBuilder()).Build()) { }
 
         ISerializer IHaveSerializer.Serializer => _serializer;
-        
+
         public AmazonS3Client Client => _client;
         public string Bucket => _bucket;
         public S3CannedACL CannedACL => _cannedAcl;
@@ -69,9 +70,13 @@ public S3FileStorage(Builder<S3FileStorageOptionsBuilder, S3FileStorageOptions>
             };
 
             var res = await _client.GetObjectAsync(req, cancellationToken).AnyContext();
-            if (!res.HttpStatusCode.IsSuccessful())
+
+            if (res.HttpStatusCode == System.Net.HttpStatusCode.NotFound)
                 return null;
 
+            if (res.HttpStatusCode != System.Net.HttpStatusCode.OK)
+                throw new S3FileStorageException($"Invalid status code {res.HttpStatusCode} ({(int)res.HttpStatusCode}): Expected 200 OK");
+
             return new ActionableStream(res.ResponseStream, () => {
                 res?.Dispose();
             });
@@ -89,16 +94,19 @@ public async Task<FileSpec> GetFileInfoAsync(string path) {
             try {
                 var res = await _client.GetObjectMetadataAsync(req).AnyContext();
 
-                if (!res.HttpStatusCode.IsSuccessful())
+                if (res.HttpStatusCode == System.Net.HttpStatusCode.NotFound)
                     return null;
 
+                if (res.HttpStatusCode != System.Net.HttpStatusCode.OK)
+                    throw new S3FileStorageException($"Invalid status code {res.HttpStatusCode} ({(int)res.HttpStatusCode}): Expected 200 OK");
+
                 return new FileSpec {
                     Size = res.ContentLength,
                     Created = res.LastModified.ToUniversalTime(),  // TODO: Need to fix this
                     Modified = res.LastModified.ToUniversalTime(),
                     Path = path
                 };
-            } catch (AmazonS3Exception) {
+            } catch (AmazonS3Exception ex) when (ex.StatusCode == System.Net.HttpStatusCode.NotFound) {
                 return null;
             }
         }
@@ -209,7 +217,7 @@ public async Task<bool> ExistsAsync(string path) {
                     continue;
 
                 deleteRequest.Objects.AddRange(keys);
-                
+
                 var deleteResponse = await _client.DeleteObjectsAsync(deleteRequest, cancellationToken).AnyContext();
                 if (deleteResponse.DeleteErrors.Count > 0) {
                     // retry 1 time, continue on.
@@ -259,9 +267,9 @@ private async Task<NextPageResult> GetFiles(SearchCriteria criteria, int pageSiz
                 Files = response.S3Objects.MatchesPattern(criteria.Pattern).Select(blob => blob.ToFileInfo()).ToList(),
                 NextPageFunc = response.IsTruncated ? r => GetFiles(criteria, pageSize, cancellationToken, response.NextContinuationToken) : (Func<PagedFileListResult, Task<NextPageResult>>)null
             };
-    }
+        }
 
-    private class SearchCriteria {
+        private class SearchCriteria {
             public string Prefix { get; set; }
             public Regex Pattern { get; set; }
         }

src/Foundatio.AWS/Storage/S3FileStorageException.cs

@@ -0,0 +1,16 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Foundatio.AWS.Storage {
+    public class S3FileStorageException : Exception {
+        public S3FileStorageException() : base() {
+        }
+
+        public S3FileStorageException(string message) : base(message) {
+        }
+
+        public S3FileStorageException(string message, Exception innerException) : base(message, innerException) {
+        }
+    }
+}