Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panics when merging custom annotation/labels #2227

Merged

Conversation

jon-signal
Copy link
Contributor

This checks that the target maps when merging custom annotations/labels are not nil, thereby avoiding panics. It fixes #2226.

@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: a6da988
  • Duration 4:10:46
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@jon-signal
Copy link
Contributor Author

Result: ❌ FAILED

I think this is from an old run, and I've since fixed the issue.

@jon-signal jon-signal force-pushed the merge_annotation_label_nil_safety branch from e356f5a to 8ff80e5 Compare February 25, 2025 16:40
@foundationdb-ci
Copy link

Result of fdb-kubernetes-operator-pr on Linux CentOS 7

  • Commit ID: e356f5a
  • Duration 3:04:18
  • Result: ❌ FAILED
  • Error: Error while executing command: if $fail_test; then exit 1; fi. Reason: exit status 1
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

Copy link
Member

@johscheuer johscheuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@johscheuer johscheuer merged commit d972078 into FoundationDB:main Feb 27, 2025
7 checks passed
@johscheuer
Copy link
Member

Thanks!

@jon-signal
Copy link
Contributor Author

Cheers! Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when adding annotations to ConfigMap
3 participants