Change the ordering of the coordinator change and the exclusion #2232
+16
−21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the ordering of the coordinator change and the exclusion. It's better to first run the exclusion and then change the coordinators, this should ensure that the processes are excluded faster, e.g. in a case where the coordinator change causes a long recovery. We previously implemented with the coordinators change first because we waited for the exclusion to complete, since we use the
no_wait
option now per default, the exclude command shouldn't timeout, expect in cases where the FDB cluster is in a bad state. So doing the exclude first and then the coordinator change seems like the better choice to ensure that the processes are quickly excluded.Type of change
Discussion
I labeled this as a bug but arguably this is not a bug.
Testing
CI will run e2e tests.
Documentation
Follow-up