Improvements to e2e tests and documentation #2233
Open
+116
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows running in clusters where a node selector is necessary.
If no storage classes in the test cluster are labeled, this test is skipped. But then AfterEach would panic when trying to revert to the empty string storage class.
The kind setup doesn't work out of the box for me. In particular some test cases of the test_operator suite that start "test" nodes in the foundationdb cluster consistently do not pass, and some others time out.
It fails to print a tab when pods are pending but don't have a matching status condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes more detailed documentation for running e2e tests, as well as one customization know that helped me start the tests in my environment, and a minor fix for a bug that prevents running e2e tests in a cluster without storage class labels.
Type of change
Please select one of the options below.
Discussion
n/a
Testing
Manually tested the code changes.
Documentation
PR includes documentation of the new setting.
Follow-up
n/a