Skip to content

Commit

Permalink
new strategy
Browse files Browse the repository at this point in the history
  • Loading branch information
FranciscoMoretti committed Oct 9, 2024
1 parent 443c32c commit ff5272e
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/modern-boats-talk.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"notion-downloader": patch
---

Created a urlEncoding naming strategy
1 change: 1 addition & 0 deletions packages/notion-downloader/src/config/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ export const MarkdownNamingStrategyNames = z.enum([
"githubSlug",
"notionSlug",
"title",
"urlEncoding",
])
export type MarkdownNamingStrategyNames = z.infer<
typeof MarkdownNamingStrategyNames
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
GuidNamingStrategy,
NotionSlugNamingStrategy,
TitleNamingStrategy,
UrlEncodingNamingStrategy,
} from "./namingStrategies"

export function getAssetNamingStrategy(
Expand Down Expand Up @@ -42,6 +43,8 @@ export function getMarkdownNamingStrategy(
return new TitleNamingStrategy()
case AllNamingSchemaName.enum.guid:
return new GuidNamingStrategy()
case MarkdownNamingStrategyNames.enum.urlEncoding:
return new UrlEncodingNamingStrategy()
case MarkdownNamingStrategyNames.enum.githubSlug:
return new GithubSlugNamingStrategy(slugProperty)
case MarkdownNamingStrategyNames.enum.notionSlug:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,3 +97,12 @@ export class TitleNamingStrategy extends NamingStrategy {
.replaceAll("--", "-")
}
}

export class UrlEncodingNamingStrategy extends NamingStrategy {
constructor() {
super([ObjectType.enum.page, ObjectType.enum.database])
}
protected _nameForObject(notionObject: NotionDatabase | NotionPage): string {
return encodeURIComponent(notionObject.title)
}
}

0 comments on commit ff5272e

Please sign in to comment.