fixes for docker.yml + toolchain.dockerfile #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add PULL=0 build-arg to LibXenon build step to force local cache add load: true to build steps to store built images locally enable BUILDKIT_INLINE_CACHE on the build steps switch to multi-stage dockerfile for libxenon for single image build fix env exports in multi-stage dockerfile Update libxenon.dockerfile Fix formatting issue for stage 2 build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for docker.yml + toolchain.dockerfile
This pull request features changes to the Github Actions docker runner job as well as the
libxenon.dockerfilebuild. My reason for this PR is I had noticed the Free60 Docker Hub images appear to be quite behind from what the Github repo has.Github Actions
Dockerfile(s)
ubuntu:21.04toubuntu:22.04toolchain.dockerfile& thelibxenon.dockerfilebuilds into a single libxenon docker image build by utilizing a multi-stage dockerfile solution (this removes thetoolchain.dockerfileand instead runs those steps as the base image in thelibxenon.dockerfilebuild)Also a question: Is there a specific reason the toolchain and libxenon images are separate other than the ability to use the
free60/toolchainimage once it's built in the next stage for buildingfree60/libxenon?