Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard address space 1.04 #574

Closed
wants to merge 3 commits into from
+176,409 −107,812
Closed

Standard address space 1.04 #574

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f569c3e
Updated standard address space to 1.04
cirp-usf Apr 5, 2018
d982366
Update xml and generate code to 1.04 spec
cirp-usf Apr 6, 2018
b8cc6da
Change type of AttributeWriteMask to UInt32 in tests
cirp-usf Apr 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change type of AttributeWriteMask to UInt32 in tests
@cirp-usf
cirp-usf committed Apr 8, 2018
commit b8cc6da6d5840870c8e96dd5a0c98b722957bb79
2 changes: 1 addition & 1 deletion tests/tests_common.py
View file
Original file line number Diff line number Diff line change
@@ -924,7 +924,7 @@ def test_data_type_to_variant_type(self):
ua.ObjectIds.Structure: ua.VariantType.ExtensionObject,
ua.ObjectIds.EnumValueType: ua.VariantType.ExtensionObject,
ua.ObjectIds.Enumeration: ua.VariantType.Int32, # enumeration
ua.ObjectIds.AttributeWriteMask: ua.VariantType.Int32, # enumeration
ua.ObjectIds.AttributeWriteMask: ua.VariantType.UInt32, # enumeration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to remove comment too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I forgot that. I'll remove it.

ua.ObjectIds.AxisScaleEnumeration: ua.VariantType.Int32 # enumeration
}
for dt, vdt in test_data.items():
2 changes: 1 addition & 1 deletion tests/tests_xml.py
View file
Original file line number Diff line number Diff line change
@@ -302,7 +302,7 @@ def test_xml_enum(self):
self._test_xml_var_type(o, "enum")

def test_xml_enumvalues(self):
o = self.opc.nodes.objects.add_variable(2, "xmlenumvalues", 0, varianttype=ua.VariantType.Int32, datatype=ua.ObjectIds.AttributeWriteMask)
o = self.opc.nodes.objects.add_variable(2, "xmlenumvalues", 0, varianttype=ua.VariantType.UInt32, datatype=ua.ObjectIds.AttributeWriteMask)
Copy link
Member

@oroulet oroulet Apr 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact that test is broken. AttributeWriteMask does not seem to inherit enum anymore...

self._test_xml_var_type(o, "enumvalues")

def test_xml_custom_uint32(self):