refactor #8 Change parameters argument to minkParameters to support a…

…utowiring (pamil) This PR was merged into the 1.0-dev branch. Discussion ---------- While autowiring Mink parameters with `$parameters` could be too much, we could setup autowiring for `$minkParameters` in SymfonyExtension. Commits ------- c693639 Change parameters argument to minkParameters to support autowiring
FriendsOfBehat · Jan 9, 2019 · 447cd6c · 447cd6c
2 parents 938cc53 + c693639
commit 447cd6c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/Element/Element.php b/src/Element/Element.php
@@ -23,11 +23,11 @@ abstract class Element
     private $document;
 
     /**
-     * @param array|\ArrayAccess $parameters
+     * @param array|\ArrayAccess $minkParameters
      */
-    public function __construct(Session $session, $parameters = [])
+    public function __construct(Session $session, $minkParameters = [])
     {
-        if (!is_array($parameters) && !$parameters instanceof \ArrayAccess) {
+        if (!is_array($minkParameters) && !$minkParameters instanceof \ArrayAccess) {
             throw new \InvalidArgumentException(sprintf(
                 '"$parameters" passed to "%s" has to be an array or implement "%s".',
                 self::class,
@@ -36,7 +36,7 @@ public function __construct(Session $session, $parameters = [])
         }
 
         $this->session = $session;
-        $this->parameters = $parameters;
+        $this->parameters = $minkParameters;
     }
 
     protected function getParameter(string $name): NodeElement

diff --git a/src/Page/Page.php b/src/Page/Page.php
@@ -24,11 +24,11 @@ abstract class Page implements PageInterface
     private $document;
 
     /**
-     * @param array|\ArrayAccess $parameters
+     * @param array|\ArrayAccess $minkParameters
      */
-    public function __construct(Session $session, $parameters = [])
+    public function __construct(Session $session, $minkParameters = [])
     {
-        if (!is_array($parameters) && !$parameters instanceof \ArrayAccess) {
+        if (!is_array($minkParameters) && !$minkParameters instanceof \ArrayAccess) {
             throw new \InvalidArgumentException(sprintf(
                 '"$parameters" passed to "%s" has to be an array or implement "%s".',
                 self::class,
@@ -37,7 +37,7 @@ public function __construct(Session $session, $parameters = [])
         }
 
         $this->session = $session;
-        $this->parameters = $parameters;
+        $this->parameters = $minkParameters;
     }
 
     public function open(array $urlParameters = []): void

diff --git a/src/Page/SymfonyPage.php b/src/Page/SymfonyPage.php
@@ -16,19 +16,19 @@ abstract class SymfonyPage extends Page implements SymfonyPageInterface
     protected static $additionalParameters = ['_locale' => 'en_US'];
 
     /**
-     * @param array|\ArrayAccess $parameters
+     * @param array|\ArrayAccess $minkParameters
      */
-    public function __construct(Session $session, $parameters, RouterInterface $router)
+    public function __construct(Session $session, $minkParameters, RouterInterface $router)
     {
-        if (!is_array($parameters) && !$parameters instanceof \ArrayAccess) {
+        if (!is_array($minkParameters) && !$minkParameters instanceof \ArrayAccess) {
             throw new \InvalidArgumentException(sprintf(
                 '"$parameters" passed to "%s" has to be an array or implement "%s".',
                 self::class,
                 \ArrayAccess::class
             ));
         }
 
-        parent::__construct($session, $parameters);
+        parent::__construct($session, $minkParameters);
 
         $this->router = $router;
     }