Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make redirect variable name configureable #686

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asgraf
Copy link

@asgraf asgraf commented Dec 28, 2022

This patch makes redirect variable name configurable via:

$action->setConfig('redirectVar', 'new_value');

Default value of 'redirect_url' for backward compatibility

@codecov
Copy link

codecov bot commented Dec 28, 2022

Codecov Report

Base: 88.84% // Head: 89.25% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (d65004e) compared to base (77a7305).
Patch coverage: 55.55% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #686      +/-   ##
============================================
+ Coverage     88.84%   89.25%   +0.40%     
  Complexity      379      379              
============================================
  Files            36       36              
  Lines          1076     1182     +106     
============================================
+ Hits            956     1055      +99     
- Misses          120      127       +7     
Impacted Files Coverage Δ
src/Traits/RedirectTrait.php 63.33% <55.55%> (+1.26%) ⬆️
src/Core/ProxyTrait.php 63.15% <0.00%> (-7.44%) ⬇️
src/Listener/RelatedModelsListener.php 66.21% <0.00%> (-3.49%) ⬇️
src/Action/AddAction.php 100.00% <0.00%> (ø)
src/Action/EditAction.php 100.00% <0.00%> (ø)
src/Action/Bulk/DeleteAction.php 100.00% <0.00%> (ø)
src/Error/Exception/ValidationException.php 100.00% <0.00%> (ø)
src/Listener/ApiListener.php 98.46% <0.00%> (+0.07%) ⬆️
src/Listener/ApiQueryLogListener.php 96.55% <0.00%> (+0.39%) ⬆️
src/Action/BaseAction.php 96.26% <0.00%> (+0.47%) ⬆️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant