Add React 18 support #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add support for React 18. For React 18,
ReactDOM.renderandReactDOM.hydrateare deprecated, so the newReactDOM.createRootandReactDOM.hydrateRootmethods must be used:https://react.dev/reference/react-dom/client/createRoot#createroot
https://react.dev/reference/react-dom/client/hydrateRoot#hydrateroot
Since the SSR examples are quite old and Hypernova has also been deprecated, I have not yet been able to extensively test the case where
hydrateRootis used. Unfortunately, I can no longer get the old SSR examples to work because the node version is too old 🙂. Can you check if it works or let me know how I can test it?